Open
Conversation
Member
Author
|
@pkienzle would you be willing to review this PR? Please let me know if you are happy with the normalisation method used here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change updates
WedgeSlicer.py, so the wedge phi parameter field in the slicer parameters window follows the same display convention as the plotted slice.Generally, phi is restricted to (-180, 180]. When phi > 180 (negative value), but delta phi brings the wedge below 180 (positive value), the plot range shows values > 180 to show an unbroken plot. To this end, checks are implemented to match the field value to the range displayed on the plot.
For example, if phi = 190 (-170) but delta_phi = 15, the plot range will be 175-205, and the phi value displayed will be 190, not -170.
Fixes #3914
How Has This Been Tested?
Manually tested on Windows 11.
Review Checklist:
Documentation
Installers
Licensing