Use native browser for help - rebased against current main#3923
Merged
Use native browser for help - rebased against current main#3923
Conversation
8 tasks
krzywon
approved these changes
Apr 17, 2026
Contributor
krzywon
left a comment
There was a problem hiding this comment.
I'm approving this and will merge it before our biweekly call next week.
There is one minor thing that can either be fixed here, or that I'll create an issue for after merging. https://www.sasview.org/docs/v6.1.2/ which is opened during unit tests, doesn't exist but does resolves as a 404 page. Older documentation is found in https://www.sasview.org/docs/old_docs/X.Y.Z/. In the future, if we move to a different web server system, the URL might not resolve, and would break the unit test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a preliminary version of the QtWebEngine-less SasView rebased against current main.
Original PR: #3847
All calls have been converted to consistent system browser calls.
References to QtWebEngine were removed.
Tests updated (although we don't run these tests, anyway)
Fixes #3511
How Has This Been Tested?
Locally win11
Review Checklist:
[if using the editor, use
[x]in place of[ ]to check a box]Documentation (check at least one)
Installers
Licensing (untick if necessary)