Repository navigation
Tests: never re-run the surefire JVM under sg - #2223
Merged
Merged
Conversation
…uns under sg (Sanne#2201) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Sanne-ai-bot
marked this pull request as ready for review
November 13, 2026 20:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2201
What
Surefire now sets
ISX_GROUP_CONTINUED=1in every test JVM (rootpom.xml), so an in-processIncusSpawn.runin a unit test never re-runs the surefire fork undersg incus-admin.mvn testpasses whatever the session's groups are.Design
Chosen: set the existing marker env in surefire's config; no production code changes (so no conflict with #2205 in
IncusSpawn.java).Alternatives: detect "not isx" in
GroupContinuation, or add a seam inIncusSpawn.run.Why: the marker already means "never continue", and
GroupContinuationTeststubscontinued(), so its coverage is unchanged.Regression test
none: a build-config change whose failure needs a session that predates
incus-adminmembership;ExitCodeTestandIncusSpawnHelpQuestionTestare the check, not reproducible on this box's session.CHARACTER
nothing
Docs
.claude/rules/commands.md(one line).Verified on
Linux box, JVM:
mvn testall green (968 tests); targeted tests pass. Native: not applicable (test config only).Handoff
none
Self-review
Self-review: review medium: 2 findings, applied 0, reverted 0, not applied 2
GroupContinuationTeststubscontinued()regardless.Follow-ups
none
Risk
low: test-only environment variable.
Timing
unit tests 9m (full
mvn test)🤖 Generated with Claude Code