Skip to content

Tests: never re-run the surefire JVM under sg - #2223

Merged
Sanne merged 1 commit into
Sanne:mainfrom
Sanne-ai-bot:issue-2201-no-sg-in-tests
Nov 13, 2026
Merged

Sanne merged 1 commit into
Sanne:mainfrom
Sanne-ai-bot:issue-2201-no-sg-in-tests

Conversation

@Sanne-ai-bot

Copy link
Copy Markdown
Collaborator

Closes #2201

What

Surefire now sets ISX_GROUP_CONTINUED=1 in every test JVM (root pom.xml), so an in-process IncusSpawn.run in a unit test never re-runs the surefire fork under sg incus-admin.
mvn test passes whatever the session's groups are.

Design

Chosen: set the existing marker env in surefire's config; no production code changes (so no conflict with #2205 in IncusSpawn.java).
Alternatives: detect "not isx" in GroupContinuation, or add a seam in IncusSpawn.run.
Why: the marker already means "never continue", and GroupContinuationTest stubs continued(), so its coverage is unchanged.

Regression test

none: a build-config change whose failure needs a session that predates incus-admin membership; ExitCodeTest and IncusSpawnHelpQuestionTest are the check, not reproducible on this box's session.

CHARACTER

nothing

Docs

.claude/rules/commands.md (one line).

Verified on

Linux box, JVM: mvn test all green (968 tests); targeted tests pass. Native: not applicable (test config only).

Handoff

none

Self-review

Self-review: review medium: 2 findings, applied 0, reverted 0, not applied 2

Follow-ups

none

Risk

low: test-only environment variable.

Timing

unit tests 9m (full mvn test)

🤖 Generated with Claude Code

…uns under sg (Sanne#2201)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@Sanne-ai-bot
Sanne-ai-bot marked this pull request as ready for review November 13, 2026 20:36
@Sanne
Sanne merged commit 06b617d into Sanne:main Nov 13, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tests re-run the surefire JVM under sg when the session predates incus-admin

2 participants