feat: support 192/128 and 256/256 ffa_fa4 in magi#331
Merged
lijinnn merged 4 commits intoJul 21, 2026
Conversation
NVIDIA-JerryChen
had a problem deploying
to
ci-internal
July 11, 2026 02:36 — with
GitHub Actions
Failure
Strivin0311
had a problem deploying
to
ci-internal
July 20, 2026 14:06 — with
GitHub Actions
Failure
lijinnn
reviewed
Jul 21, 2026
lijinnn
left a comment
Collaborator
There was a problem hiding this comment.
Hello! Excited to work together. 🙌
I noticed that the pre-commit checks failed for this PR: #331.
Could you please refer to our contributing guide (https://github.com/SandAI-org/MagiAttention/blob/main/CONTRIBUTING.md) to run the pre-commit checks locally, fix the formatting, and update your commit?
Thank you so much!
lijinnn
reviewed
Jul 21, 2026
lijinnn
reviewed
Jul 21, 2026
NVIDIA-JerryChen
had a problem deploying
to
ci-internal
July 21, 2026 05:34 — with
GitHub Actions
Failure
NVIDIA-JerryChen
had a problem deploying
to
ci-internal
July 21, 2026 06:52 — with
GitHub Actions
Failure
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
head_dim_vpropagation and support SM100 configurations:KV Communication
(256, 256)path keeps the existing sequence-axis fusion withpacked_times=2.(192, 128)path uses MLA-style K/V packing:packed_times=1;concat_kv/concat_dkvsequence-axis packing.CSR Tile Mapping
(192, 128)backward K2Q CSR metadata uses128x256blocks.(256, 256)backward K2Q CSR metadata uses256x128blocks.Validation
n_func <= 13.Related PR