[optimization] Implement RemoveRedundantLayoutOpsPass - #842
Merged
Conversation
Introduce the optimization pass that removes redundant Reshape and Transpose operations. TICO-DCO-1.0-Signed-off-by: seongwoo <mhs4670go@naver.com>
shs-park
reviewed
Jul 27, 2026
shs-park
left a comment
shs-park
left a comment
Contributor
There was a problem hiding this comment.
AI found one or more actionable issues in this PR.
Please check the inline comments when present.
Reviewed by AI via personal agents
| if _check_perm(perm_data, producer_perm_data): | ||
| # The two transposes cancel out, connect to producer's input | ||
| main_input = producer_inputs[0] | ||
| transpose_op.inputs = [main_input] + list(inputs[1:]) |
Contributor
There was a problem hiding this comment.
Inverse transposes are not actually cancelled because the surviving transpose_op keeps its original permutation input.
For Transpose([1,0]) -> Transpose([1,0]), this rewires the second op to produce Transpose(input, [1,0]) instead of the original input, changing model outputs.
Contributor
Author
There was a problem hiding this comment.
Good point! I've resolved that problem. PTAL:)
Contributor
|
This PR is too large for the default AI review.
Please split the change or request a narrower follow-up review. Reviewed by AI via personal agents |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce the optimization pass that removes redundant Reshape and Transpose operations.
Related: #829
TICO-DCO-1.0-Signed-off-by: seongwoo mhs4670go@naver.com