fix: simplify agent state timestamp calculation#3
Merged
Conversation
Instead of calculating secondsAgo and converting back to timestamp, now directly return Unix timestamp from getAgentState(). This is cleaner and avoids the redundant calculation: Before: time.Now().Unix() - secondsAgo After: timestamp (direct)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As suggested in PR #2 review by @juliusv:
Changes
Instead of:
secondsAgofrom modTimesecondsAgotime.Now().Unix() - secondsAgo(redundant)Now:
getAgentState()secondsAgointernally only when needed for state logicThis is cleaner and avoids the redundant calculation.