fix(versioning): use dolt table import -r for row loading (handle empty strings in typed cols) - #20
Merged
Merged
Conversation
The push-commits endpoint rebuilt the rows into per-row INSERT INTO... VALUES statements and ran them through dolt sql. Empty strings in datetime/date/numeric columns (a common artifact of MySQL running with sql_mode='') reached the SQL verbatim and Dolt rejected them with 'Incorrect datetime value: '''. Switched to dolt table import -r against a per-table temp CSV file - the same command the client uses locally. Dolt's CSV parser performs the type coercion the schema expects (empty string -> NULL for typed columns) so empty strings in DATETIME/INT columns now land as NULL instead of crashing the request. Bonus: one subprocess per table instead of one per row, so pushes with thousands of rows are an order of magnitude faster. 277 unit tests pass; lint clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Push crashed the server with 'Incorrect datetime value: ''' when a row had empty string in a typed column (common MySQL sql_mode='' artifact). The server built per-row INSERT INTO...VALUES statements and ran through dolt sql; empty strings reached SQL verbatim. Switched to dolt table import -r against per-table CSV temp files — same command the client uses, with native type coercion. Empty strings in DATETIME/INT now land as NULL. Bonus: O(tables) subprocesses instead of O(rows).
277 unit tests pass; lint clean.