fix(versioning): import CommitImportError in push-commits router - #19
Merged
Conversation
`POST /api/v1/versioning/repos/:repoId/push-commits` returned 500 with 'ReferenceError: CommitImportError is not defined' because the router's catch-block tested `instanceof CommitImportError` but the class was never named in the import list. Hit on every real push (deltix push to a fresh repo), missed by every test (none pushed a payload that triggered the error path). Same class of bug as promptSecret-not-imported (Deltix-Client v0.7.6). 277 unit tests pass; lint clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POST .../push-commitsreturned 500 with 'ReferenceError: CommitImportError is not defined' — the router's catch testedinstanceof CommitImportErrorbut the class wasn't in the import block. Hit on every real push from a fresh repo; missed by tests because none pushed a payload that triggered the error path. Same class of bug as Deltix-Client v0.7.6 (promptSecret-not-imported).277 unit tests pass; lint clean.