fix(versioning): global admins have implicit access to all repos - #18
Merged
Conversation
Before: a global admin hitting /repos/:id/log (or any data endpoint) without an explicit per-repo role grant got a 403, even though isGlobalAdmin=true is the highest privilege the system grants. The role-management helpers (requireRepoRoleOrGlobalAdmin) already had this bypass, but the data endpoints did not. Operators provisioning a repo from one account, then logging in with another (e.g. a personal 'hemiblade' alongside the bootstrap 'admin'), got locked out. After: any user with isGlobalAdmin=true resolves to role='admin' on any repo that exists. The non-admin fallback is unchanged. 277 unit tests pass; lint clean.
… change The test name + assertion + comment described the OLD design (global admin does NOT get implicit data access). The new design (see fix/global-admin-implicit-repo-access) does grant implicit access, so the test now asserts 200 instead of 403 with a comment explaining the real-world motivation (operator locked out of their own repo when switching accounts).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any user with isGlobalAdmin=true resolves to role='admin' on any existing repo (data endpoints). Removes the chicken-and-egg that locked out operators provisioning from one account and using another. Role-management endpoints already had this bypass; data endpoints did not. 277 unit tests pass; lint clean.