fix(cli): deltix log -n <repo> works regardless of flag order - #47
Merged
Conversation
The previous destructuring `const [repoArg, ...flags] = args` in runLog assumed the first arg was always the repo name. When the user typed `deltix log -n 5 hmc-sync`, '-n' became repoArg and the command failed with 'Repo not found: -n'. Added a splitPositionalsAndFlags helper that separates any arg starting with '-' (and its value) from positional args, so flags can appear before or after the repo name — same behavior as git log -n 5 <branch>. 8 new unit tests for the helper; 128 tests pass; lint clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous destructuring
const [repoArg, ...flags] = argsin runLog assumed the first arg was always the repo name. When the user typeddeltix log -n 5 hmc-sync,-nbecame repoArg and the command failed withRepo not found: -n.Added a
splitPositionalsAndFlagshelper that separates any arg starting with-(and its value) from positional args, so flags can appear before or after the repo name — same behavior asgit log -n 5 <branch>.