feat(cli): configure prompts for local Dolt port; remove all client-side gRPC - #46
Merged
Merged
Conversation
Two related cleanups in one release:
1. deltix configure now prompts for the local Dolt SQL bind host AND
port (default 127.0.0.1:3306) and persists both to
~/.deltix/config.json. Previously the operator had to export
DELTIX_LOCAL_PORT=... every time they wanted to start the local engine
on a non-default port. Persisted via the existing 'localPort' field
(v0.7.3 mechanism) + a new 'localHost' field. Env vars still take
precedence for CI/automation, but the human-facing path is now
command-driven.
2. Removed gRPC transfer pipeline entirely from the client. The legacy
Fase 3 path (DELTIX_ENABLE_GRPC_TRANSFER) was transitional and slated
for removal; the commit-based REST push/pull (Fase 5.9) is the only
path now. Deleted:
- src/contexts/dataflow/ (5 files)
- src/contexts/heartbeat/ (3 files)
- src/acl/grpc-transfer-client.ts
- src/acl/transfer-ticket-api-adapter.ts
- corresponding unit + integration tests
Removed from shared/env.ts:
- DELTIX_GRPC_HOST, DELTIX_GRPC_PORT
- DELTIX_GRPC_TLS_CA_PATH, DELTIX_GRPC_TLS_SERVER_NAME_OVERRIDE
- DELTIX_HTTP_TLS_CA_PATH / DELTIX_HTTP_TLS_SERVER_NAME_OVERRIDE
no longer fall back to the gRPC equivalents (no gRPC TLS to fall
back to)
- DELTIX_HEARTBEAT_INTERVAL_MS
- DELTIX_ENABLE_GRPC_TRANSFER (the feature flag itself)
Removed from StoredConfig: grpcHost, grpcPort, grpcTlsCaPath,
grpcTlsServerNameOverride.
Removed deps: @grpc/grpc-js, @grpc/proto-loader.
Updated runConfigure: removed the two gRPC questions (host/port), uses
the parsed REST URL's host:port for the TOFU cert fetch instead of a
separate gRPC port.
Removed the gRPC fallback branch in runPull.
120 unit tests pass; lint clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two cleanups in one PR:
deltix configurenow prompts for the local Dolt bind host AND port (default 127.0.0.1:3306) and persists both. Previously the operator had toexport DELTIX_LOCAL_PORT=...every time. Env vars still take precedence for CI, but the human path is now command-driven.Removed gRPC transfer pipeline from the client entirely. The legacy Fase 3 path (DELTIX_ENABLE_GRPC_TRANSFER) was transitional; the commit-based REST push/pull is the only path now. Deleted dataflow/ + heartbeat/ contexts, grpc-transfer-client.ts, transfer-ticket-api-adapter.ts, the @grpc deps, the DELTIX_GRPC_* env vars, and the gRPC fields on StoredConfig. Updated runConfigure to use the REST URL for the TOFU cert fetch.
120 unit tests pass; lint clean.