Repository navigation
Release Godot addon 1.3.0 with verified runtime scope - #145
Merged
Merged
Conversation
Samfa12-tech
marked this pull request as ready for review
October 17, 2026 02:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pocket Chordsmith Godot1.3.0 combines the reviewed PR143/144 changes: Core/Campfire prepared playback, full native DAW arrangement import, section/gain/ending correctness, owned asynchronous loading, and explicit prepared-passage controls. Runtime/editor/import/resource GDScript is identical to tested head e00f946; this final commit only records release acceptance and Godot metadata. DAW/web/DJ/Core product trees are unchanged from main.
Both human Core/native listening checks passed in standalone and synchronized modes with music/SFX, restart and Stop. The final finite replay had21,600 steady intervals below33.333ms (maximum18.061ms); seven whole-run setup/import/diagnostic overruns remain retained. Historical intermittent stalls were not reproduced, cause unknown. Dummy timing remains failed. The owner accepted this limitation for the separately verified Godot4.6.3 Windows/WASAPI target. No universal hitch-free or historical-stall-fixed claim is made.
PR143/144 each finished all16CI/CodeQL checks green. This consolidation requires its own final CI/CodeQL green and addon-only package verification/clean-project smoke. Store/Library metadata targets4.6, tested4.6.3; Store upload remains the owner's action. Exact release artifacts/provenance are recorded separately after packaging/publication. Supersedes PR143/144 without deleting their branches or evidence.