Repository navigation
Godot: remove path warnings and verify native player modes - #144
Closed
Samfa12-tech wants to merge 2 commits into
Closed
Samfa12-tech wants to merge 2 commits into
Samfa12-tech wants to merge 2 commits into
Conversation
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ordinary pack-path checks emitted Unexpected-NUL diagnostics because
String.chr(0)warns and returns U+FFFD in Godot4.6.3. This replaces that construction with the same character directly, preserving the existing rejection behavior. A31check regression covers valid Unicode, invalid/traversal paths and intentional ZIP-directory versus asset-path differences; CI rejects NUL diagnostics in that probe.The musical measurement harness also saved both native player modes to the same manifest-adjacent profile, overwriting the first. It now saves distinct profiles and verifies actual active-player ownership after Play. Previous duplicate-mode claims are withdrawn; the original evidence remains.
This is a separate follow-up to frozen PR143
2fb2f49df3659402d9290b6c6ed98dd2498ee700, rather than rewriting its independently reviewed source or artifacts. Its old hosted job tested mergea8ebba0dc53ca6f3e662de342c254f76738aa802and retained206 NUL diagnostics; it is not relabelled as diagnostic-free or direct-head provenance.Validation:
See
addons/pocket_chordsmith/docs/{NUL_DIAGNOSTIC_CAUSE_2026-10-17,RUNTIME_FOLLOWUP_2026-10-17}.mdfor exact scopes and superseding ledger. Production audio clock/renderer, released DAW/web/DJ/Core bytes, public Godot1.2.0 and Sam's listing prose remain unchanged. No final release ZIP, public upload, Store API access, microphone recording or deletion. Independent follow-up review and human/performance acceptance remain required before publication.