Repository navigation
Preserve live Library focus during background readiness - #136
Merged
Merged
Conversation
Samfa12-tech
changed the base branch from
codex/daw-ordinary-stop-ownership-20261017
to
main
October 16, 2026 23:28
Samfa12-tech
marked this pull request as ready for review
October 16, 2026 23:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final installed 0.6.57 review status
Exact tested source fc619a1 remains independently source accepted. Prepared once; frozen public setup SHA-256 c1c23d12fa3e0a3fa6237d8bb7299e109411af93ba931a972c250c0103370567, receipt SHA-256 3466c0c6915a7d6153e83a87c3e8abe567fe38ec98212f98c9d697b7c72de5e5. No source changes, rebuild or restage after freezing.
Official evidence-only candidate verification passed. Required installed release evidence passed the unchanged validators. The current exact-installed human checks include native Open/Cancel, Chordsmith JSON import, visible updater result, audible guitar/responsive Stop, and Finish Apply/Undo/Redo gain restoration while retaining the export-area view.
Source/prepare gates passed1,291 source tests/108files,224 Rust tests/6 explicit ignores,77 production browser cases/0skips. Hosted CI passed all13 jobs and both CodeQL languages. Full reviewed source/browser producer evidence below remains unchanged.
Installed media portability/export, receipt-matched VST3 hosting and Godot/Chromium pack import/decode gates passed. Target decoding does not establish representative-game timing or physical backend parity; the standalone Godot addon hold remains separate.
Detailed installed attestation, validation reports and private recording-related evidence remain local for private review. This status-only section intentionally excludes recording-derived metrics and hashes. Earlier recording-derived details in the installed section have been removed.
The initial attestation metadata check found a missing required Godot evidence description. Its failed check remains retained; the completed description passed unchanged validators before the one successful official candidate-verification run. No test/assertion/threshold was weakened. Original transport/cancellation diagnostic failures and their scoped successful companions also remain retained.
Parent review, exact main/tag/tested-commit agreement and publication remain pending. PR stays draft. No merge, upload of private evidence, product publication or storage cleanup occurred.
Historical pre-install source checkpoint
The lower text and JSON are preserved from the source-review checkpoint before the final installer and installed validation existed. Statements below such as no installer, no hardware action or no microphone action describe that earlier checkpoint only. The final installed verification status above supersedes them. The original source/browser evidence, complete77-case inventory and hashes below remain unchanged.
A delayed background readiness refresh replaced active Library controls after the existing3.5-second startup check, losing focus and unfinished input. Defer that redraw while a Library workbench control owns focus; readiness state and notifications still update, and intentional surface changes display the latest results. Explicit updater actions remain available.
Review exact source fc619a1, 0.6.57, based on scoped-accepted PR135/38f70df3b81280e6bbcb1982907dbbf6c63f7fe6. Product change: one early condition in shouldDeferReadinessRender. Native timing, DSP, capture, save/undo and the existing transport/hint fixes are unchanged.
Validation:15 deterministic UI controls failed before and passed after; full source1291/108; TypeScript/build and metadata/governance checks passed. Complete unprofiled production browser 77 passed,0 skipped,0 retries, including unchanged150ms worker gates at11.7/98.9ms. Real natural-timer control lost focus on0.6.56 and retained it on0.6.57.
0.6.56's first prepare stopped before packaging on two development-browser failures; the controlled retry was deliberately stopped before packaging after focus loss reproduced. No0.6.56 installer or receipt exists. Its cold Finish deadline cause remains unassigned. All failed/diagnostic runs and frozen0.6.54/private0.6.53 identities remain retained. No0.6.57 installer, installation, microphone action, merge or publication. New source requires independent review; whole installed gates remain.
Immutable local review seal SHA256 71966ba9aa7f023e3c827bab6d6f1d2d269f15766afd1f7573f3ddd2189f5a5c. Compact cloud report SHA256 69972a69c8234b9838cd403b75d4c5c45a5080095b0d25a346250a19279d8964; complete77-case inventory SHA256 f86c09520c9d17b467b80d1939b288ac789aaa3be240e37265c1f936ac068dd0. Full relevant non-sensitive report follows; no recording, credentials or profile contents included.
{ "head": "fc619a1dfaacf8c07b86147b5dcbf39058e56032", "tree": "2845dfa4a1d59c32008f7b65ebbc046dbf26fe41", "base": "38f70df3b81280e6bbcb1982907dbbf6c63f7fe6", "version": "0.6.57", "tests": { "sourcePassed": 1291, "sourceFiles": 108, "targetedBeforeMetadata": { "failedBefore": 15, "passedAfter": 15 }, "production": { "stats": { "startTime": "2026-10-16T22:20:51.416Z", "duration": 96544.321, "expected": 77, "skipped": 0, "unexpected": 0, "flaky": 0 }, "passed": 77, "failed": 0, "skipped": 0, "retries": 0, "workers": 4, "profilerEnabled": false, "heartbeatLimitMs": 150, "workerChecks": { "long-song-worker-responsiveness": { "durationSeconds": 300, "bytes": 115200044, "transferred": true, "beats": 26, "maxGapMs": 11.699999988079071, "workerError": null, "completedBeforeCancel": false, "elapsedMs": 261.80000001192093, "cancelAndSettleMs": 100.90000000596046 }, "completed-long-song-worker-analysis": { "seconds": 300, "sampleRate": 48000, "bytes": 115200044, "elapsedMs": 6200.700000017881, "beats": 611, "maxGapMs": 98.90000000596046, "analysisAcknowledgedMs": 8.200000017881393, "longTasks": [ { "atMs": 3170.7000000178814, "durationMs": 59, "name": "self" } ], "largeGaps": [ { "atMs": 3269.600000023842, "durationMs": 98.90000000596046 } ], "visibility": "visible", "hardwareConcurrency": 12, "metrics": { "durationSeconds": 300, "sampleRate": 48000, "channelCount": 2, "eventCount": 0, "peak": 0.2, "samplePeakDbfs": -13.9794, "truePeakDbtp": -13.9794, "estimatedTruePeakDbtp": -13.9794, "truePeakMethod": "estimated_blackman_sinc_4x32_v3", "intersampleRisk": false, "rms": 0.141421, "rmsDbfs": -16.9897, "integratedLufs": -14.627938, "lufsMethod": "estimated_bs1770_k_weighted_gated_v3", "meteringStatus": "estimated_pending_external_calibration", "crestFactorDb": 3.0103, "clippedSamples": 0, "nanSamples": 0, "infiniteSamples": 0, "nonFiniteSamples": 0, "dcOffsetL": 0, "dcOffsetR": 0, "stereoCorrelation": 1, "silenceAtStartMs": 0.020833, "tailSeconds": 0.000021, "spectralBalance": { "sub": -82.840975, "bass": -75.827347, "lowMid": -60.92594, "mid": -67.343019, "presence": -80.44196, "air": -88.370481 }, "zeroCrossingRate": 0.03125, "quantizedSampleHash": "b3726d85" } } } }, "typescriptBuild": "passed", "metadataCiGovernanceOrganizationWhitespace": "passed", "rustClippy": "not rerun for UI-only follow-up; base native results historical" }, "command": { "argv": [ "C:\\Program Files\\nodejs\\node.exe", "C:\\Users\\sam_s\\Documents\\Codex\\2026-10-15\\task-3\\daw-library-readiness-focus\\apps\\pocket-daw\\node_modules\\@playwright\\test\\cli.js", "test", "--workers=4", "--output", "C:\\Users\\sam_s\\Documents\\Codex\\2026-10-15\\task-3\\daw-library-readiness-focus\\local-artifacts\\scratch\\readiness-review\\production-traces" ], "launch": { "startedAt": "2026-10-16T22:20:50.9639933Z", "command": "node node_modules/@playwright/test/cli.js test --workers=4 --output <reviewArea>/production-traces", "cwd": "C:\\Users\\sam_s\\Documents\\Codex\\2026-10-15\\task-3\\daw-library-readiness-focus\\apps\\pocket-daw", "staticDirectory": "C:\\Users\\sam_s\\Documents\\Codex\\2026-10-15\\task-3\\daw-library-readiness-focus\\apps\\pocket-daw\\dist", "browsersPath": "C:\\Users\\sam_s\\Documents\\Codex\\2026-10-15\\task-3\\pocket-audio\\local-artifacts\\scratch\\validation\\playwright-browsers", "profilerEnabled": false, "workers": 4, "heartbeatLimitMs": 150 }, "environment": { "POCKET_DAW_UI_STATIC_DIR": "C:\\Users\\sam_s\\Documents\\Codex\\2026-10-15\\task-3\\daw-library-readiness-focus\\apps\\pocket-daw\\dist", "POCKET_DAW_WORKER_PROFILE": "unset" } }, "bundles": [ { "name": "event-Cox3n_FW.js", "sha256": "f9debc1dd313aa89ff5a1a4bae3dff735815f090995445771f417a5f9b111e23" }, { "name": "finishAnalysis.worker-JxszY5wB.js", "sha256": "9c358a6e68e590b49ffe73c4c5354d1795fc3193774b29d69e4fc86dab73e0d8" }, { "name": "index-2S2VYe_8.js", "sha256": "bef5816da9d99ad59b72daf55da97c7f0082b53bcb63267eba6ed25f8ac4359f" }, { "name": "index-C2DQKSAv.js", "sha256": "fcf23e11b9e9e8c01ecf2c64ec98dcc414a623e75392418f44ec42461fbcc360" }, { "name": "index-D_TwrdR5.js", "sha256": "3abe6c99705bb5b797ecbfebcafc8f3485e2f8f7516aef2f7bc05c2a9d2ec810" }, { "name": "index-D_XbQU2j.js", "sha256": "aee5130d5c18a7115cb3ac6bb5dbacf8494eb190c0823d41b21d8b6c67cd21d2" }, { "name": "webview-BvNqWtdd.js", "sha256": "f98c00358e4257c2751c4bf537e33ec3a61141073187c88ca416b849163807e3" } ], "hashes": { "fullBrowserReport": "2acbd8d3f86eb219db0de8bb567b332ecd8ea8e47b3026492f020068471a5494", "redReport": "337d76d3f9f45a6b5f0730db6ea917eca710bd6e679293c19b9e5a5787517217", "fixedTargetedReport": "e44fb59e00bf2c09f35ed0a51fd1b4d23d6bb550f194041cbf3969fbe24463f0", "sourceLog": "9bbafe926aa86ed6b7312ceb9ec3c03226f644853ca6e3b222381d50197ae7c7", "uiBuildLog": "09bb9f068e31cef93549d43eee3ad932ef7b1d84cb0e99d9d9fd8510aa9828b7", "runtimeAfter": "7f61c2f1e282b7309f5666a87857df4909f3cf56cc850f6ba237f776c503f5e3", "previous056Withheld": "7c59af5f2e1237cad65557220478c984555120e1605e1ba7a59061b61e7f5cd4" }, "naturalTimer": { "beforeVersion": "POCKET_DAW_VERSION = \"0.6.56\"", "beforeFocused": false, "afterVersion": "POCKET_DAW_VERSION = \"0.6.57\"", "afterFocused": true, "waitAfterSelectionMs": 4500 }, "captureFingerprint": "e9da9acb8d6235a4f26f74f1c3601289d77c4125299cb345bb0fbf82956c8bce", "frozen054": { "setup": "f19442ff76dbe390a59602094a2c0defba2c231aa143eb06145afca923bb8961", "receipt": "6868868088324dae111fcbf15bab0dbb5ff3e0f1c920bb3f774460738db78a0d", "unchanged": true }, "publishedFamilyExact": "a31ffae545e0d50b5024dd1be746b834d6f7bed3", "addonExact": "4f156e2c9857b40f7c79b3d6761d77c6683545d2", "retainedFailures": [ "Original0.6.56 development prepare58pass/2skip/2fail retained. Its retry was deliberately stopped before packaging after the real delayed focus defect reproduced.", "Earlier fixture-construction runs held native library initialization and timed out waiting for nonexistent rows; corrected fixture initializes it before holding later readiness. Those attempts remain retained and are not the15 product red controls.", "First0.6.57 full source run omitted retained browser runtime env:1277pass/14skip and parity suite launch failed. Correct-runtime complete1291pass retained.", "Cold Finish deadline and historical153.2/208.3ms worker outlier causes remain unassigned; no timeout, assertion or worker-limit relaxation." ], "remaining": [ "Independent exact-head review and hosted CI", "Prepare one final exact candidate after review progression; no installer exists", "Preserve recovered user work before installed checks, transport timings/cancellation/native UI/import/updater", "Final deliberate current PCM/MIDI/export readiness and evidence-only candidate verification", "Godot runtime/listing holds and Horde deferral unchanged" ], "newInstaller": false, "newInstallation": false, "microphoneActions": 0, "merge": false, "publication": false, "spend": 0 }Complete77-case outcomes: