Repository navigation
Guard target inspection and explicit clone conflicts before import - #2
Merged
Merged
Conversation
SamZebrado
marked this pull request as ready for review
October 6, 2026 04:09
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Import now rejects unknown or occupied targets before mutation, including explicit clone IDs equal to the source ID, and selects JSONL files by exact session metadata. It preserves unrelated files and documents repeat/conflict behavior and import safety limits.
Validation: independent exact-commit review passed 82 repository tests, 12 adversarial checks, and 4 repair-edge checks. Earlier failures are preserved privately. The existing Ubuntu/macOS Python 3.10/3.13 fixture CI remains unchanged. Aggregate SQLite ResourceWarnings remain visible.
Acceptance uses disposable synthetic fixtures. Stopped target writers remain required; real sessions, live SQLite/WAL consistency, cross-file rollback, bundle integrity, and live Codex/schema compatibility remain unverified.