Repository navigation
fix: contain session import paths and add offline fixture CI - #1
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
SamZebrado
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Importing a bundle with an absolute explicit session ID could write JSONL outside the supplied Codex home. Validate bundle and explicit IDs as filename-safe values, preserve UUID and non-UUID IDs, and check all rewritten JSONL destinations before backups, deletions, or writes. Reject escaping session and temporary-file symlinks. Correct checksum and backup-recovery documentation to describe manual checksum auditing and manifest-directed recovery.
The existing offline fixture CI is retained with pinned actions, read-only permissions, and Linux/macOS Python 3.10/3.13 coverage.
Validation: 52 synthetic stdlib tests pass locally on Python 3.14.2 and cached Python 3.12.14; the new path regressions cover absolute IDs, both separators, traversal, invalid and valid IDs, basename containment, symlinks and mutation-free preflight. Manual restore of a closed fixture database and JSONL matches the original bytes. No real Codex sessions/workdirs or external agents were used.
Limits: import does not automatically verify bundle checksums or provide cross-file rollback. Live Codex schema/Desktop/extension compatibility, cross-OS real migrations and concurrent mutation remain unverified. The repair requires fresh independent review before merge. A follow-up preserves the
.jsonlextension and rewrites only the terminal source ID in the filename stem, including short IDsjsonlandlwith overlapping prefix text. The copied independent probe now passes all 58 cases; original failing evidence is preserved.