[SamGu-NRX]

Stacked on #4. Base: feat/minimal-product-20261007.

What changed

Onboarding scans the photos the user takes

Onboarding asks the user to photograph their fridge and pantry, but the review step never looked at those photos. After a short delay it showed 14 hard-coded ingredients with made-up confidences labelled as Vision results, and "Add to My Kitchen" wrote them into the real Kitchen. A stir-fry photo produced bread, eggs and butter at 94%.

The review now runs the same recognition as Scan Ingredients (VisionService.scan) on the captured photos, fridge and pantry separately. ConfidenceRouter decides what starts checked, as in the main review. OnboardingKitchenDemoDetections is deleted; nothing else used it. The logic is in OnboardingKitchenScan.swift, and the screen is OnboardingKitchenReviewStep in OnboardingInventorySteps.swift.

Empty, failed and partial scans say what happened

Situation	What the review shows
No photos taken	"No photos to scan", Continue
Photos scanned, nothing found	"We didn't find ingredients in these photos. You can add them from Kitchen any time.", Continue
Scan failed	"Couldn't read your photos", Try Again or Continue; nothing is saved
One location failed	The other location's items stay reviewable; the failed section has its own Try Again
Some photos unreadable	Found items plus "Some fridge photos couldn't be read.", Try Again

Unreadable means every Vision request failed on a crop. On the simulator, classification always fails while OCR works, and that doesn't raise this warning.

Confirming twice never duplicates, loses or revives food

The user can go back and confirm again any number of times.

• One transaction per run: each confirmation is one ingestConfirmedScan call under a single session reference for the onboarding run, so it saves completely or not at all. An item that moves between the fridge and pantry sections on a rescan stays one lot. Food that was cooked in between isn't added back.
• Lots filed by photo: lots are stored under the location of the photo they came from (ScanLotLocation.photographed(byIngredient:)). They used to land under "Other". If an added ingredient has no location, intake throws IntakeError.missingLocation instead of guessing. The main scan passes .inferredFromIngredient and behaves as before.
• What a scan can't speak for is kept: ingestConfirmedScan takes a required preserving set, and lots for those ingredients are left exactly as they are. Onboarding preserves an earlier-confirmed item when its section's latest scan failed, had unreadable photos, or has no photos now, as long as the item isn't shown and the user hasn't unchecked it. The main scan passes [].
• Choices last the run: check and uncheck choices survive rescans, failures and retries. Only foods seen for the first time start checked.
• Failed saves: a failed save shows "Couldn't save to your Kitchen" with Try Again and Continue Without Saving, the same pattern as the main review. Try Again retries the confirmation the user made, even if a late photo import has refreshed the review behind the alert.
• Navigation: a photo that finishes importing after the review opens triggers a rescan instead of leaving the screen stuck, and leaving mid-scan stops the remaining work. Back from "You're ready" now returns to the review; it used to replay the setup animation and come straight back.

Capture and accessibility fixes found on the way

• Library imports now go through ScanImagePreprocessor.prepare, so orientation and the 1600 px cap apply.
• FLCaptureView records whether each photo came from the shutter or the library, through a new FLCapturedPhoto. The old [UIImage] initialiser still works for its other callers.
• Remove buttons on photo thumbnails, in onboarding and the shared camera screen, have 44 pt targets and names like "Remove fridge photo 2".
• VoiceOver announces when the scan finishes or fails, and focus moves to the review heading.
• The "0 of N selected" row shows an empty circle instead of a check, and a section with one result says "1 item".

Verification

• Simulator walkthrough at 1ead827 (iPhone 17, iOS 26.5):
  • Fridge photo: the taco scenario. Pantry photo: the stir-fry scenario.
  • The review showed the real detections: cheese and beans at 55% unchecked, soy sauce at 90% checked.
  • After confirming, the database held cheese (120 g, estimate) filed under fridge and soy sauce (30 g, estimate) under pantry.
  • Back from "You're ready" returned to the review, and confirming again added nothing.
  • Kitchen showed Fridge 1 and Pantry 1 with "≈ 120g est." and "≈ 30g est.".
• Earlier walkthrough at 6829370: skipping both photos showed "No photos to scan", and unchecking an item on a revisit retired its lot.
• Screenshots (local): ~/.long-run/fridgeluck/evidence/lead-verify/ (onboarding-review-taco.png, kitchen-after-onboarding-revisit.png, kitchen-final-onboarding.png).
• Full simulator suite at 1ead827: 192 of 192 passed. The 42 tests in OnboardingKitchenReviewTests drive OnboardingKitchenIntake.commit against a real migrated database, covering:
  • an item moving between sections, untouched, partly consumed and fully consumed
  • failed, unreadable and photo-less sections
  • a forced write failure that leaves nothing changed
  • a retry after a refresh
• 21dd039 only changes the section-count text; the whole-app typecheck passes on it.
• Not checked: the save-failure alert by hand, VoiceOver announcement timing, Dynamic Type layout and motion.

Checklist

• The scope is focused; related changes belong together
• I explained what changed and why
• N/A uploaded before/after images: gh can't attach images. The screenshots listed above are local files
• N/A video: no new motion

🤖 Generated with Claude Code

[coderabbitai]

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

• Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}