Skip to content

ci: run iOS CI on macos-26 with Xcode 26.6 and a 20-minute timeout - #10

Merged
SamGu-NRX merged 1 commit into
mainfrom
ci/xcode-26-runner
Oct 7, 2026
Merged

SamGu-NRX merged 1 commit into
mainfrom
ci/xcode-26-runner

Conversation

@SamGu-NRX

@SamGu-NRX SamGu-NRX commented Oct 7, 2026 •

Copy link
Copy Markdown
Owner

What changed

iOS CI now runs on the macos-26 image with Xcode 26.6 pinned, and both jobs time out after 20 minutes.

The app's deployment target is iOS 26.0, but macos-15 only ships Xcode 16.4 and the iOS 18.5 simulator. On #6, the build finished and then the test launch hung: Xcode warned that "the iOS Simulator deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 26.0, but the range of supported deployment target versions is 12.0 to 18.5.99". The job ran until GitHub's 6-hour default cancelled it (run 37622461677).

  • Image: macos-26 (arm64) ships Xcode 26.0.1 through 26.6, with iOS 26.0–26.5 simulators that include iPhone 17 Pro, the device resolve_ios_sim_destination.sh asks for first (image readme).
  • Pinned Xcode: DEVELOPER_DIR pins Xcode 26.6, so a change to the image's default can't silently swap the toolchain.
  • Timeout: timeout-minutes: 20 on both jobs. In the cancelled run, the clean build took about 2 minutes (12:39:36 to 12:41:27), and the suite runs in seconds locally, so 20 minutes leaves room for a cold build and simulator boot. The limit isn't tuned beyond that.

Why

The app stays on iOS 26, its declared target. Moving CI to iOS 26 is a smaller change than lowering the target. #2 stays open for its author to decide.

Verification

  • The workflow parses as YAML.
  • This PR's own CI run is the test of the new image; its result is reported on this PR.

Checklist

  • The scope is focused; related changes belong together
  • I explained what changed and why
  • N/A before/after images: CI configuration only
  • N/A video: no UI

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated iOS build and test workflows to use a newer macOS and Xcode environment.
    • Added a 20-minute limit to the build and test job.

The app targets iOS 26.0, but macos-15 only has Xcode 16.4 and the iOS
18.5 simulator. The test launch hung there until GitHub's 6-hour default
cancelled the job. Both jobs now run on macos-26 with Xcode 26.6 pinned
and a 20-minute timeout.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-07T20:30:02.661707Z ef7afca PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 635312e4-2335-4433-b693-9990cbde852e
📥 Commits

Reviewing files that changed from the base of the PR and between 1f85e88 and ef7afca.

📒 Files selected for processing (1)
  • .github/workflows/ios-ci.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

Both iOS CI jobs now run on macos-26 and select Xcode 26.6 through DEVELOPER_DIR. Each job has a 20-minute timeout.

Changes

iOS CI Runner Updates

Layer / File(s) Summary
Configure iOS CI jobs
.github/workflows/ios-ci.yml
Both jobs now use macos-26, select Xcode 26.6 through DEVELOPER_DIR, and have a 20-minute timeout. The build-and-test job comments now describe the iOS target, simulator, and timeout. The dead-code-advisory dependency on build-and-test is unchanged.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to ef7af

No actionable merge-blocking risk is evident in the supplied review context.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main changes: moving iOS CI to macos-26, selecting Xcode 26.6, and adding a 20-minute timeout.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codemetrics-ai

codemetrics-ai Bot commented Oct 7, 2026

Copy link
Copy Markdown

Note

Review skipped

Codemetrics is installed on this repository, but it hasn't been added to your team yet.

To enable AI code reviews for this repo, go to your dashboard and add FridgeLuck to your team's repositories.

@SamGu-NRX
SamGu-NRX merged commit 1151588 into main Oct 7, 2026
3 checks passed
@SamGu-NRX
SamGu-NRX deleted the ci/xcode-26-runner branch October 15, 2026 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant