Skip to content

Add ruff as linter and formatter & codex - #8

Merged
Sam-v6 merged 10 commits into
mainfrom
feature/add-profiling
Dec 5, 2025
Merged

Sam-v6 merged 10 commits into
mainfrom
feature/add-profiling

Conversation

@Sam-v6

@Sam-v6 Sam-v6 commented Dec 5, 2025 •

Copy link
Copy Markdown
Owner

What does this PR do?

Adds linter and formatter

What are some specific details on the changes?

  • Adding ruff as a linter and formatting tool
  • Addresses all ruff warnings and formats
  • Setup precommit hooks with ruff auto fixing warnings and formatting
  • Updated README to include ruff info
  • Added codex so it can review PRs and add features as needed

How has this been tested?

No capability changing things, pipeline covers impact

Important Notes

None

Checklist

  • [ X ] Tests have been added or updated to cover the changes.
  • [ X ] Documentation has been updated (if necessary)

Sam-v6 and others added 10 commits December 2, 2025 12:30
- Switching from pth to pt to avoid path confusion
- Conslidating the instattion of tranformer model in it's own function for consistency
- Started manually addressing some of the Pylint warnings
- Added ruff for proper linting, going to run checks
- Added mypy for type hinting
@Sam-v6 Sam-v6 changed the title Add linter and formatter Add ruff as linter and formatter Dec 5, 2025
@Sam-v6

Sam-v6 commented Dec 5, 2025

Copy link
Copy Markdown
Owner Author

@codex Give me a general review on this codebase since it's your first time seeing it

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Bravo.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Sam-v6 Sam-v6 changed the title Add ruff as linter and formatter Add ruff as linter and formatter & codex Dec 5, 2025
@Sam-v6
Sam-v6 merged commit 1c1607b into main Dec 5, 2025
1 check passed
@Sam-v6
Sam-v6 deleted the feature/add-profiling branch December 5, 2025 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant