Repository navigation
Consolidate determinism into configure_determinism and clarify fused AdamW behavior - #13
Merged
Sam-v6 merged 4 commits intoDec 31, 2025
Conversation
Sam-v6
deleted the
codex/make-transformer-training-process-deterministic
branch
December 31, 2025 20:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
torch.Generatoris produced and used for deterministicDataLoadershuffling.Description
configure_determinism(deterministic: bool, seed: int = 42)which setsPYTHONHASHSEED, Python/NumPy/PyTorch seeds, creates and returns a seededtorch.Generator, and toggles cuDNN/TF32/deterministic algorithm flags based ondeterministic.run_trialwithg = configure_determinism(deterministic, seed=42)wheredeterministicis driven byargs.profile.gintoDataLoader(..., generator=g)and set the optimizer tofused=not deterministicforAdamW, with an updated comment explaining the non-deterministic reductions.AdamWdeterminism to address earlier reviewer questioning.Testing
Codex Task