Repository navigation
Name the tests after the classic look, not another product - #2
Merged
Merged
Conversation
Seven test methods still carried another file manager's name; they now describe the behaviour on its own terms. Only the method names change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renames seven xunit test methods whose names referenced another file manager, so they describe the behaviour on its own terms. Only the method names change - no bodies, no other files.
NothingConfiguredMeansTheTableFarInstallsNothingConfiguredMeansTheWindowsNtTableFarStyleExcludesFollowAPipeClassicStyleExcludesFollowAPipeToDisplayString_UsesFarNotationToDisplayString_UsesTheClassicNotationTheFarPanelPairIsDeepNavyAndBrightCyanTheClassicPanelPairIsDeepNavyAndBrightCyanScrollBarGlyphsAreTheFarOnesScrollBarGlyphsAreTheClassicShadesANewThemeAlreadyCarriesTheFarPaletteANewThemeAlreadyCarriesTheClassicPaletteTheDefaultTabStopIsEightMatchingFarAndTheViewerTheDefaultTabStopIsEightMatchingTheClassicConsoleAndTheViewerTheDominantPanelPairIsFarCrisperUnderVgaThanUnderCampbellandMaxDepthLimitsHowFarTheWalkGoesuse the English word and are left alone. None of the renamed tests had a doc comment naming the product.Test plan
dotnet test tests/OpenStus.Tests/OpenStus.Tests.csproj- 1842 passedFar[A-Z]|\bFar\boutside README.md, docs/index.html and NOTICE.md matches only the two English-word tests above🤖 Generated with Claude Code