Skip to content

fix: apply Dodge to every Dexterity save - #153

Merged
dajiaohuang merged 1 commit into
mainfrom
fix/131-dodge-dex-saves
Sep 1, 2026
Merged

fix: apply Dodge to every Dexterity save#153
dajiaohuang merged 1 commit into
mainfrom
fix/131-dodge-dex-saves

Conversation

@dajiaohuang

Copy link
Copy Markdown
Contributor

Closes #131.

What changed

  • derive Dexterity-save advantage from the authoritative encounter combatant in the shared domain resolver
  • reuse the Dodge lifecycle helper introduced by fix: end invalid Dodge benefits permanently #142, including effective-speed and incapacitation handling
  • route structured spells, generic combat checks, content activities, semantic saves, and area save-damage settlement through that encounter-aware resolver
  • normalize ability aliases/casing/whitespace before matching and retain the Dodge rule receipt when advantage and disadvantage cancel

Validation

  • full domain test suite
  • full modified MCP test files for combat transactions, structured spells, and agent save damage
  • focused generic-save, Fireball, Dragonborn Breath, area-save, CAS, idempotency, random-stream, no-write, and Dodge lifecycle coverage
  • Core rule-pack and official-expansion lock tests
  • ruff check packages/domain packages/mcp
  • git diff --check

@dajiaohuang
dajiaohuang force-pushed the fix/131-dodge-dex-saves branch from 8cd14d5 to d20218d Compare September 1, 2026 07:08
@dajiaohuang
dajiaohuang merged commit 9f4ea8b into main Sep 1, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Apply 2014 Dodge to every Dexterity saving-throw path

1 participant