Skip to content

fix: enforce edition-specific Search checks - #140

Merged
dajiaohuang merged 1 commit into
mainfrom
fix/132-search-check-contract
Sep 1, 2026
Merged

fix: enforce edition-specific Search checks#140
dajiaohuang merged 1 commit into
mainfrom
fix/132-search-check-contract

Conversation

@dajiaohuang

@dajiaohuang dajiaohuang commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Summary

  • enforce source-specific Search contracts for 2014 and 2024
  • derive Search proficiency and modifiers from the actor card
  • validate the complete Search action boundary before rolling or persistence

Source

Bundled SRD 2014 Order of Combat: Search uses Wisdom (Perception) or Intelligence (Investigation). The 2024 rule remains edition-separated and uses Wisdom, optionally with the listed skills.

Validation

  • 5 focused Search MCP regressions
  • action payment, stale revision, idempotency replay, random no-consumption, and failure no-write coverage
  • Ruff and CI

Closes #132

@dajiaohuang
dajiaohuang merged commit fb3edc1 into main Sep 1, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Restrict the 2014 Search action to Perception or Investigation

1 participant