Skip to content

fix: enforce actor knowledge audience boundaries - #138

Merged
dajiaohuang merged 1 commit into
mainfrom
fix/137-actor-knowledge-audience
Sep 1, 2026
Merged

fix: enforce actor knowledge audience boundaries#138
dajiaohuang merged 1 commit into
mainfrom
fix/137-actor-knowledge-audience

Conversation

@dajiaohuang

Copy link
Copy Markdown
Contributor

Closes #137.

What changed

  • reject player-visible ActorKnowledge backed by DM-only events across campaign_event, direct knowledge CRUD, and atomic memory_change(commit) paths
  • validate effective preserved source/disclosure values on revise while retaining explicit source clearing
  • make committed NPC conversations actor-visible without exposing private authority snapshots or accepted DM commitments
  • align fixtures, tool descriptions, and D&D DM memory guidance with the provenance/disclosure boundary

Validation

  • uv run ruff check packages/mcp/src packages/mcp/tests
  • Domain suite: all passed
  • MCP suite: all passed, 1 skipped
  • focused audience/memory/NPC suite: 25 passed
  • D&D Module Generator Skill validator passed
  • UI typecheck, 9 tests, and production build passed
  • independent complex gpt-5.6-luna campaign backtest pending before merge

@dajiaohuang
dajiaohuang merged commit d114c42 into main Sep 1, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prevent Keeper-only events from backing player-visible actor knowledge

1 participant