fix: expose Luna module draft contracts - #130
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fresh Luna callers could reach
module_draft(start/get/evidence)but tools/list exposedpayloadas an open object, so the required Pack manifest and source-backed D&D play profile were discoverable only through runtime failures.Solution
Malformed Pack edits now leave the job revision, result, and edit history unchanged.
Verification
uv run --package sagasmith-dnd-mcp pytest packages/mcp/tests(full suite; one existing skip)uv run --package sagasmith-dnd pytest packages/domain/testsuv run --package sagasmith-dnd-mcp pytest packages/mcp/tests/test_module_draft_contract.py packages/mcp/tests/test_three_tool_authoring_mcp.py packages/mcp/tests/test_tool_contract_quality.py packages/mcp/tests/test_full_skill_parity.py(18 passed after rebasing onto latest main)uv run ruff check packages/domain packages/mcppython skills/dnd-module-generator/scripts/validate_skill.py skills/dnd-module-generatorCloses #125