fix(agent): restore modern domain context after restart - #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After a persisted Narrative conversation and Hosted Agent restart, the MCP reconnects but pre-turn authoritative context synchronization raises
unsupported schema.Modern MCP wrappers intentionally remove trusted
campaign_idfrom the model-visible input schema and retain it in_trusted_arguments. The synchronizer only recognized a visibleaction + campaign_idpair, so the exact moderncampaign_queryshape was rejected before the wrapper could inject the Host-owned campaign.Solution
actionremains visible and the MCP wrapper explicitly advertises trustedcampaign_idaction=getfor that shape, letting the bound request context inject/override campaign identityview + payloadand visibleaction + campaign_idcompatibilityVerification
uv run ruff check nanobot --select Fuv run ruff check nanobot/agent/loop.py tests/agent/test_domain_context.pyuv run python -m pytest -q tests/agent/test_domain_context.py(16 passed)uv run python -m pytest -q tests/agent/test_domain_context.py tests/tools/test_mcp_tool.py tests/tools/test_mcp_v2_contract.py tests/apps/test_hosted_worker.py(141 passed)uv run python -m pytest -q tests(5393 passed, 73 skipped)Regression coverage persists and reloads a Narrative session across a simulated process restart, registers a freshly reconnected modern campaign tool, verifies v2 trusted campaign injection, and covers unsupported untrusted schemas plus cross-campaign rejection.