fix(hosted): stabilize workspace ownership - #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Hosted Worker used
worker:<ephemeral port>as the owner stored in its workspace marker. A retry or process restart on another port therefore could not reclaim the same persisted conversation workspace, even though the trusted Host intentionally selected the same path.Solution
--workspace-idThe path binding prevents one stable ID from silently naming another workspace. A different owner still cannot claim an existing marker.
Integration contract
Supervisors launching
sagasmith-agent-workermust add:Retries and restarts for the same persisted workspace must reuse the same value even when the worker port changes. Different workspaces must receive different values.
Verification
uv run ruff check nanobot --select Fuv run ruff check nanobot/apps/hosted_workspace.py nanobot/apps/hosted_worker.py tests/apps/test_hosted_workspace.py tests/apps/test_hosted_worker.pyuv run python -m pytest -q tests/apps(26 passed)uv run python -m pytest -q tests(5390 passed, 73 skipped)Regression tests cover a port-changing restart/retry, path binding, cross-owner rejection, ambiguous ID rejection, and the required CLI contract.