fanknob 1.5.1 - #10
Merged
Merged
Conversation
Owner
Author
|
Correction to the checked list above: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version bump for the release. Once this is merged I'll tag
v1.5.1onmainand the workflow takes over.What ships
Three fixes, all of them corrections to things fanknob was reporting inaccurately (#9):
daemonReachable(), which only completes aconnect()— the kernel accepts that into the listen backlog whether or not the daemon can still answer. The app could show a green "fan control available" light at the same moment it showed "daemon timed out", with the controls enabled and doing nothing. It's now derived from thestateround-trip the same poll already performs.EPIPEwas mapped to.system, so a client hitting its own timeout produced a "Broken pipe" line every time — burying real incidents under hundreds of them./var/log/fanknobd.logacross reboots, so lines previously couldn't be lined up with a boot or a bug report.Also on
mainsince 1.5.0 but shipped in 1.5.0's wake: the thermal watchdog keeps maximum cooling active when it trips (#8).No features and no breaking changes, hence a patch bump.
Deferred
#9 originally retried a daemon command whose reply timed out, so the app would stop reporting an error for a change that had in fact been applied. Review found two real defects — a retried timed
setextends its own hold, and re-execution disturbs the watchdog's debounce state — neither fixable without request-ID deduplication or a richerstatereply. Both are protocol changes, so it's deferred to 1.6.0.Checked
make print-version→1.5.1, andmake appstampsCFBundleShortVersionString: 1.5.1into the bundle.CFBundleVersionis the commit count, 98, up from 96 at v1.5.0 — it has to increase monotonically.make ui-testhas not been run for this release. It covers the fan-control light, which is the only user-visible change here.🤖 Generated with Claude Code