bug: fix statCell animation of number rolling and alignment issues#889
Conversation
|
Hi @Abfa41, thanks for contributing to InternHack! 🎉 I have automatically:
Our workflows will now analyze your changes to classify:
Tip Ensure your PR description references the issue it resolves (e.g. Happy coding! 🚀 |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe hero section's animated stats counters are corrected to eliminate horizontal text shifting during number updates. The ChangesStats Counter Layout Fix
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@Sachinchaurasiya360 broh, Please review my Small PR and merge it bro. All the checks have been passed. You can refer the ScreenRecordings as well for better understanding. Thanks! |
|
@Sachinchaurasiya360 broh, Please review my PR as early as possible and do let me know if any changes are required or not?? |
297f47b
into
Sachinchaurasiya360:main
Description
This PR fixes the animated stats counter shifting issue in the hero section. The NumberFlow counters were visually moving from left to right while updating from
0to their target values due to dynamic text width expansion.Changes made:
w-[6ch]) to the stats number containertext-rightalignment to anchor digits consistentlytabular-numsfor equal-width digit renderingRelated Issue
Fixes #888
Type of Change
Testing
Tested manually by:
Screenshots/ScreenRecordings
Before the Fix ( The number rolling animation is coming from left to right, making it look bad )
https://github.com/user-attachments/assets/ad3b1904-5f26-4de9-8f77-aecb3c549862
After the Fix ( The number rolling animation is coming properly and looking smooth )
https://github.com/user-attachments/assets/85d3502a-f14b-4480-b3f9-87c9bfa47fac
Checklist
.env, credentials, ornode_modulescommittedSummary by CodeRabbit