Skip to content

Pre-compress subcode files with Zstd #1007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mnadareski merged 3 commits into from
Jul 7, 2026
+12 −4
Merged

Pre-compress subcode files with Zstd #1007

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
07d0f12
Pre-compress subcode files with Zstd
Deterous Jul 7, 2026
707737f
subcode isnt required
Deterous Jul 7, 2026
67c077f
fix tests
Deterous Jul 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELIST.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
### WIP (xxxx-xx-xx)

- Pre-compress subcode files with Zstd
Comment thread
mnadareski marked this conversation as resolved.

### 3.8.3 (2026-07-06)

- Add live tool output console for the Linux GUI (gmipf)
Expand Down
4 changes: 2 additions & 2 deletions MPF.Processors.Test/RedumperTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ public void GetOutputFiles_CDROM_Populated()
var processor = new Redumper(PhysicalSystem.IBMPCcompatible);

var actual = processor.GetOutputFiles(PhysicalMediaType.CDROM, outputDirectory, outputFilename);
Assert.Equal(19, actual.Count);
Assert.Equal(20, actual.Count);
}

[Fact]
Expand Down Expand Up @@ -161,7 +161,7 @@ public void FoundAllFiles_Invalid_Filled()
string outputFilename = string.Empty;
var processor = new Redumper(PhysicalSystem.IBMPCcompatible);
var actual = processor.FoundAllFiles(PhysicalMediaType.CDROM, outputDirectory, outputFilename);
Assert.Equal(5, actual.Count);
Assert.Equal(4, actual.Count);
}

[Fact]
Expand Down
8 changes: 6 additions & 2 deletions MPF.Processors/Redumper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,8 @@ public override void GenerateSubmissionInfo(SubmissionInfo info, PhysicalMediaTy
_ = CompressZstandard($"{basePath}.skeleton");
if (File.Exists($"{basePath}.state"))
_ = CompressZstandard($"{basePath}.state");
if (File.Exists($"{basePath}.subcode"))
_ = CompressZstandard($"{basePath}.subcode");

// Pre-compress all skeletons for multi-track CDs
if (File.Exists($"{basePath}.cue"))
Expand Down Expand Up @@ -571,8 +573,10 @@ internal override List<OutputFile> GetOutputFiles(PhysicalMediaType? mediaType,
new($"{outputFilename}.state.zst", OutputFileFlags.Binary
| OutputFileFlags.Zippable,
"state_zst"),
new($"{outputFilename}.subcode", OutputFileFlags.Required
| OutputFileFlags.Binary
new($"{outputFilename}.subcode", OutputFileFlags.Binary
| OutputFileFlags.Zippable,
"subcode"),
new($"{outputFilename}.subcode.zst", OutputFileFlags.Binary
| OutputFileFlags.Zippable,
"subcode"),
new($"{outputFilename}.toc", OutputFileFlags.Required
Expand Down