Skip to content

fix(frontend): remove demo credentials hint from login - #241

Merged
SabaTech-dev merged 2 commits into
mainfrom
fix/remove-demo-creds-hint
Sep 14, 2026
Merged

SabaTech-dev merged 2 commits into
mainfrom
fix/remove-demo-creds-hint

Conversation

@SabaTech-dev

Copy link
Copy Markdown
Owner

Summary

  • Login page advertised Demo: admin / admin123, but those credentials do not exist in prod (beta is closed, invite-only — decision 13-sep, option C).
  • Replaced hint with neutral copy: "Acceso por invitación".

Scope

Copy-only, 1 file (Login.tsx). No DB changes. No credentials in code, commits, or logs.

Verification

  • npm run build — OK (vite build, 11s)
  • npx vitest run — 11 files / 83 tests passed

Workboard card: e9ed429d-a901-4107-acac-3fa21c8ec335

@github-actions

Copy link
Copy Markdown

PR Check Results

Code Formatting: Passed
Linting: Passed
Type Checking: Failed
Tests: Failed

⚠️ Some checks failed. Please review the details above.

@github-actions

github-actions Bot commented Sep 14, 2026

Copy link
Copy Markdown

⚠️ WARN Trivy Security Scan Results

Severity Count
🔴 CRITICAL 0
🟠 HIGH 42
Total 42

Scans performed:

  • 📁 Filesystem (vulnerabilities, secrets, misconfigurations)
  • 🐳 Backend Docker image
  • 🐳 Frontend Docker image
  • 🏗️ IaC misconfiguration detection

⚠️ HIGH vulnerabilities should be addressed. Review required.

📋 View detailed SARIF reports

Download artifacts from this workflow run for full SARIF reports.
Results are also available in the GitHub Security tab.


Trivy v0.71.0 | aquasecurity/trivy

@SabaTech-dev

Copy link
Copy Markdown
Owner Author

Deploy note: PR is mergeable content-wise but mergeStateStatus: BLOCKED (branch protection / required review), so CI/CD cannot auto-deploy without a human gate. Railway frontend service (qa-framework-frontend, Dockerfile.prod) will deploy automatically on merge to main. Leaving PR ready for review+merge.

@github-actions

Copy link
Copy Markdown

PR Check Results

Code Formatting: Passed
Linting: Passed
Type Checking: Failed
Tests: Failed

⚠️ Some checks failed. Please review the details above.

@github-actions

Copy link
Copy Markdown

🔧 Backend Preview Deployment

App Coolify: qa-framework-backend-pr-241 (npe8iqqaa3bizhioabortx5m)
Estado: ⚠️ running:unknown
Commit: 980d5a44ff616f4171d44c05703d0fb1dd6c2a39
Branch: fix/remove-demo-creds-hint

Preview interna (sin FQDN público hasta decisión de proxy — card 52a85645).

@github-actions

Copy link
Copy Markdown

🎨 Frontend Preview Deployment

App Coolify: qa-framework-frontend-pr-241 (2kssvbngc2goy3rkndaswtts)
Estado: ⚠️ running:unknown
Commit: 980d5a44ff616f4171d44c05703d0fb1dd6c2a39
Branch: fix/remove-demo-creds-hint

Preview interna (sin FQDN público hasta decisión de proxy — card 52a85645).

@SabaTech-dev
SabaTech-dev merged commit d9b33b6 into main Sep 14, 2026
41 checks passed
@github-actions

Copy link
Copy Markdown

🧹 Preview Cleanup

PR #241 - Merged

✅ Preview apps eliminadas de Coolify (verificado via API): backend + frontend.


Resources freed at 2026-09-14T06:54:51.975Z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant