Conversation
Collaborator
There was a problem hiding this comment.
현재 GridProductAdapter와 WishProductAdapter가 동일한 레이아웃과 바인딩 로직을 공유하고 있습니다. 이를 별도의 어댑터로 나누기보다, 하나의 ProductAdapter로 통합하는 것도 좋을거 같습니다! 필수는 아니니 참고만 해주세요!
Comment on lines
+15
to
+22
| <TextView | ||
| android:id="@+id/txtName" | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:text="상품 이름" | ||
| android:textSize="20dp" | ||
| android:textStyle="bold" | ||
| android:paddingTop="6dp"/> |
Collaborator
There was a problem hiding this comment.
현재 XML의 모든 TextView에서 textSize 단위로 dp를 사용 중인데, 시각 장애가 있거나 큰 글씨를 선호하는 사용자의 시스템 설정에 대응하려면 sp 단위를 사용하는 것이 안드로이드 표준 가이드입니다!
Comment on lines
+34
to
+36
| } | ||
|
|
||
| override fun getItemCount() = items.size |
Collaborator
There was a problem hiding this comment.
단순히 items.size를 반환하는 것보다, 데이터 변경 시 성능 최적화를 위해 ListAdapter와 DiffUtil을 적용해볼 수도 있습니다! 그러면 getItemCount를 직접 오버라이드할 필요 없이 더 스마트하게 리스트를 관리할 수 있어요!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 PR 제목
[feat] 3주차 미션_RecyclerView 구현
🔗 관련 이슈
Closes #19
✨ 변경 사항
🔍 테스트
📸 스크린샷 (선택)
🚨 추가 이슈