Repository navigation
Add local transaction signing commands and bundle validation - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
nockchain inspectandnockchain signto the npm package, plusinspectSigningBundleandsignSigningBundlelibrary functions. Users save a bundle from the remote MCP, review it locally, and sign with a hidden zprv prompt or an explicit local key file. Recovery phrases require an explicit derivation path. The command requires interactive approval, creates a new file with mode 0600, and does not broadcast.Validation reconstructs the payment plan from complete inputs and checks canonical encoding, commitments, existing signatures, maturity, recipients, change and fees, including small remainders assigned to fees. Existing signature verification can allow missing signatures without weakening its default threshold check. Network and tip fields remain indexed context, not a chain proof.
Implements the signing contract in https://github.com/SWPSCO/nockchain-rpc-server/pull/139. Sets the package version to 0.3.0 and includes the executable in the npm archive; package publication is separate.
Validation: