Drop dead AI bindings + retype SVFG def/use-site bindings - #56
Merged
bjjwwang merged 2 commits intoMay 4, 2026
Merged
Conversation
Upstream PR #1812 (sparse-AE refactor) and the follow-up SVFG-API commit
moved getUseSitesOf{Obj,Val}Var and getDefSiteOf{Val,Obj}Var from
AbstractInterpretation onto the FullSparseAbstractInterpretation
subclass. The dense base class no longer exposes them, so pybind/AE.cpp
fails to compile on master with "is not a member of
SVF::AbstractInterpretation".
Drop the four bindings (and the matching pyi stubs). Equivalent
def/use-site queries live on SVFG and are still bound there; pysvf does
not currently expose FullSparseAbstractInterpretation, so there is
no replacement to wire up here.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Upstream commit e4e02013 ("add/update SVFG APIs for sparseAE") retyped
SVFG::getDefSiteOf{Val,Obj}Var and getUseSitesOf{Val,Obj}Var to return
SVFGNode (sets of SVFGNode) and to take SVFGNode* in place of
ICFGNode*. pybind11 fails to compile against svf-lib >= 1.0.2558:
cannot convert 'const SVF::ICFGNode*' to 'const SVF::SVFGNode*'
Update pybind/Graphs.cpp to use the new signatures, return
std::vector<const SVFGNode*>, and adjust pysvf.pyi to match. Callers
that need the ICFG node can map back via SVFGNode::getICFGNode().
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
bjjwwang
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getUseSitesOf{Obj,Val}VarandgetDefSiteOf{Val,Obj}VarfromAbstractInterpretationonto theFullSparseAbstractInterpretationsubclass — drop the four bindings + matching.pyistubs.add/update SVFG APIs for sparseAE) retyped the same-named methods onSVFGto take/returnSVFGNode*instead ofICFGNode*. Updatepybind/Graphs.cppandpysvf.pyiaccordingly. Callers that need the ICFG node can map back viaSVFGNode::getICFGNode().CI was failing on svf-lib >= 1.0.2558 with both error families.
Test plan
ubuntu:24.04Docker againstnpm install svf-lib@latest(1.0.2558, LLVM 21.1.0, Z3 4.8.8):Successfully built pysvf-0.0.0.dev0-cp312-cp312-linux_x86_64.whl.pysvf.AbstractInterpretation+Options.max_field_limit()) from a non-source cwd.mypy.stubtest pysvf --allowlist ./stubtest_allowlist.txt→Success: no issues found in 4 modules.🤖 Generated with Claude Code