Skip to content

feat: per-server rules with a hub-based settings UI - #30

Open
NebulaTechs wants to merge 6 commits into
SU4G3:mainfrom
NebulaTechs:feature/per-server-rules-and-ui
Open

NebulaTechs wants to merge 6 commits into
SU4G3:mainfrom
NebulaTechs:feature/per-server-rules-and-ui

Conversation

@NebulaTechs

Copy link
Copy Markdown

What does this change

Replaces the single flat tabbed settings screen with a hub-based layout, and moves
every protection option from a global setting to a per-server rule.

The hub. The settings screen was one long tabbed page that mixed every option
into a single flat list, so the options that only make sense for one server and the
ones that are purely client-local were impossible to tell apart and impossible to
scope. It is replaced by a hub with three destinations: per-server rules, the
account manager, and the client-wide settings.

Per-server rules. The server profiles map becomes an ordered list of rules, each
carrying its own copy of the settings, plus a mandatory ANY rule that always
exists as the fallback for servers no other rule matches. The ANY rule holds the
global baseline, is always enabled, always applied last, and cannot be deleted, so
the effective settings of a server are "the first matching rule, otherwise the ANY
rule" rather than "the profile for this address, otherwise whatever was left over".

Rules match by the address the player typed, not only by the resolved IP, so a rule
can target play.example.com without caring which address it points at today. A
rule matches by EXACT address, REGEX, or resolved IP, and its Applies To
field takes a comma-separated list so one rule can cover a whole set of servers.

Config migration. The config file carries a version field. A file without one is
a v1 file and is migrated on load: the global settings move into the ANY rule and
the server profiles become EXACT rules. A file with a higher version is refused
outright - loading it would silently drop the fields it contains, and writing back
would destroy them, so the file is left untouched and the UI says so. A v2 file also
writes the global settings to the old top-level key as a redundant copy, so an
older build reading that file still finds the global defaults where it expects them.

Other changes in this PR:

  • Cloth Config is now a required dependency for all four trees. The settings UI
    is built with it, so the mod will not start without it.
  • AntiExploitPreventer ghost-sign detection. AEP's TranslationChecker plants a
    sign on the player's own feet block, opens the sign editor at that position and
    reads back whatever text the client sends. A vanilla client never has a sign on the
    block it stands in, so the sign appearing there can only have been made up by the
    server. The sign editor is left alone when this happens - cancelling it would make
    the client behave in a way no vanilla client can - but the user is now told it
    happened.
  • The pack-cache clear and trust controls that existed in the old tabbed screen
    are restored in the new one. They were unreachable after the hub layout replaced
    the hand-rolled screen, while their language keys stayed in the locale files.
  • The README is updated for the new layout and the new dependency.

Build trees touched

  • Fabric (src/, Stonecutter — ran ./gradlew buildAll or targeted :<version>:compileClientJava)
  • neoforge/ (1.21.1)
  • neoforge-1.21.11/
  • neoforge-26.2/
  • N/A — change doesn't touch mod code (docs, workflows, templates, etc.)

Testing

  • Compiled on the affected tree(s)/version(s)
  • Launched the client (runClient) and exercised the changed behavior
  • N/A

Builds run:

Command Working directory Result
./gradlew buildAll repository root BUILD SUCCESSFUL — all 12 Stonecutter targets compiled
./gradlew build neoforge/ BUILD SUCCESSFUL
./gradlew build neoforge-1.21.11/ BUILD SUCCESSFUL
./gradlew build neoforge-26.2/ BUILD SUCCESSFUL

buildAll covers every Fabric version the project targets (1.20.1, 1.20.2, 1.20.4,
1.20.6, 1.21.1, 1.21.4, 1.21.6, 1.21.9, 1.21.11, 26.1, 26.2, 26.3), and the shared
source set is compiled against each of them separately, since the Stonecutter
//? blocks mean a version that is not selected is not compiled at all. The three
NeoForge trees are independent Gradle projects and are each built on their own.

The two files touched by the last commit (SettingsScreen.java) carry no
Stonecutter conditionals, so the same source is compiled on every target.

The only warnings are pre-existing mixin-mapping warnings in files this PR does not
touch (GameConnectionProxyMixin, PacketProcessorMixin, DownloadQueueMixin,
ComponentSerializationMixin) and a deprecation notice in CloudflarePingRelay.

Not done: the client was not launched to exercise the changed behavior at runtime.
The new settings UI, the rule matching and the AEP detection are therefore
compile-verified only.

Checklist

  • I read CONTRIBUTING.md
  • No tokens, account data, IPs, or credentials included in this diff or its test fixtures

NebulaTechs and others added 6 commits November 20, 2026 17:13
The settings UI is rebuilt on Cloth Config (sub-categories, per-field
validation, save/cancel), so it is now a compile-time and runtime
dependency rather than an optional one.

The CC release line is not semver-safe across MC lines, so the version is
pinned per MC version instead of being resolved from a range. Each
versions/<v>/gradle.properties carries its own cloth_config_version:
11.1.136 for 1.20.1 through 26.3.159 for 26.3 on Fabric, and 15.0.140 /
21.11.160 / 26.2.155 on the three NeoForge trees.

A range would be actively wrong here: 21.11.160 declares ">=1.21.9-",
which numerically admits 26.x, but its jar still ships the old
render(GuiGraphics,...) path and references net.minecraft.resources.Identifier
-- a class that does not exist on 1.21.9/1.21.10. Resolving it by range
puts that jar on 1.21.9 and crashes the game with NoClassDefFoundError.
The runtime depends entry therefore pins the exact version too.

The dependency is declared as required in fabric.mod.json and in each
neoforge.mods.toml, so a missing Cloth Config is reported at launch
instead of failing later with a class-not-found.
The settings screen was one long tabbed page that mixed every option into a
single flat list, so the options that only make sense for one server and the
ones that are purely local were impossible to tell apart and impossible to
scope. It is replaced by a hub with three destinations: per-server rules, the
account manager and the client-local settings.

The configuration model changes with it. The server profiles map is now an
ordered list of rules, each carrying its own settings, and a single ANY rule
always exists as the fallback for servers no other rule matches. The ANY rule
holds the global baseline, is always enabled, always applied last and cannot be
deleted, so the effective settings of a server are "the first matching rule,
otherwise the ANY rule" rather than "the profile for this address, otherwise
whatever was left over".

The config file carries a version field. A file without one is a v1 file and
is migrated on load: the global settings move into the ANY rule and the
server profiles become EXACT rules. A file with a higher version is refused
outright - loading it would silently drop the fields it contains, and writing
back would destroy them, so the file is left untouched and the UI says so.

A v2 file also writes the global settings to the old top-level key as a
redundant copy. An older build reading that file then still finds the global
defaults where it expects them instead of coming up empty.

Rules are matched by the address the player typed, not only by the resolved
IP, so a rule can target "play.example.com" without caring which address it
points at today. The typed address is captured before the connection is
resolved and claimed again once the server sends its login packet.

The client information normalizer claims en_us in the outgoing handshake, so
everything a server can read back has to be en_us too. Server pack
translations are now kept per locale, and a keybind rendered in the player's
real locale is replaced with the en_us default.

The settings button on the multiplayer screen list is back, now opening the
hub, and can be turned off in the settings screen. It stays on by default
because without Mod Menu it is the only way into the settings in-game.
AntiExploitPreventer's TranslationChecker works by planting a sign on the
player's own feet block, opening the sign editor at that position and reading
back whatever text the client sends. A vanilla client never has a sign on the
block it stands in, so the sign appearing there can only have been made up by
the server.

The sign editor is left alone when this happens. Cancelling it would make the
client behave in a way no vanilla client can - a vanilla client always sends
the sign update when the editor closes - and the checker waits for that reply
without a timeout, so a client that stays quiet pins one server-side thread
per probed key. The text the probe is after is already reduced to the raw
translation key by the translation protection, so the only thing missing was
telling the user it happened.

The alert goes through a per-category burst limit. AEP plants one sign per
known mod translation key, which is enough of a burst to flood the chat with
alerts and make the client itself the most noticeable thing in the log.
Alerts inside the window are dropped from the chat and toast pipeline, while
every event is still recorded.
The local agent run directories are not part of the project and should not
show up as untracked files.
…ngs UI

The hub-based settings screen replaced the hand-rolled tabbed one, and two
controls that existed before it were dropped in the swap: "Clear Cached
Resource Packs" and "Trust This Server (Skip Auto-Purge)". Their language
keys were still in the locale files, so nothing warned that the features
had become unreachable - the strings were there, the UI entry points were
not.

Both are global rather than per-server. The clear button acts on the pack
cache as a whole, and the trust toggle exempts the bucket of the server
that is connected right now, which is a single address rather than
something a rule could own: the exemption set is keyed by server address
and is independent of how rules match.

The toggle is only added while a server is connected, because there is no
current server to exempt otherwise. The clear button has to be injected
into the Cloth Config list, which has no button entry type, so it takes
the row that was reserved below the list.

Co-authored-by: sisyphus-dev-ai <sisyphus-dev-ai@users.noreply.github.com>
The README still described the old flat tabbed settings screen and said
NeoForge needed no dependency beyond itself. Both stopped being true when
the settings screen moved to Cloth Config and the tabs became a hub, so
the install instructions would have left people without the mod they need
for the settings screen to open at all.

The layout tables are rewritten around what the screens actually are now -
the hub, the per-rule options, and the client-wide settings - and the
per-server rules feature gets a section of its own, since the matching
rules are the part a reader cannot guess from the option names alone.

Co-authored-by: sisyphus-dev-ai <sisyphus-dev-ai@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Nov 20, 2026

Copy link
Copy Markdown

Important

Review skipped

Too many files!

This PR contains 203 files, which is 103 over the limit of 100.

To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch.

Upgrade to a paid plan to raise the limit.

CodeRabbit couldn't verify your organization's usage billing state, so no usage-priced review was started. Retry after the billing service recovers.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 47c6bee5-d6e4-4992-8332-ef31fd8c4ba5
Commits

Reviewing files that changed from the base of the PR and between 8cfcd63 and e919e8d.

Files selected for processing: 203

  • .gitignore
  • README.md
  • build.gradle
  • neoforge-1.21.11/build.gradle
  • neoforge-1.21.11/gradle.properties
  • neoforge-1.21.11/src/main/java/aurick/opsec/mod/PrivacyLogger.java
  • neoforge-1.21.11/src/main/java/aurick/opsec/mod/config/AccountManagerScreen.java
  • neoforge-1.21.11/src/main/java/aurick/opsec/mod/config/AddAccountScreen.java
  • neoforge-1.21.11/src/main/java/aurick/opsec/mod/config/AddCrackedAccountScreen.java
  • neoforge-1.21.11/src/main/java/aurick/opsec/mod/config/CloudflareRelaySettingsScreen.java
  • neoforge-1.21.11/src/main/java/aurick/opsec/mod/config/GameProxySettingsScreen.java
  • neoforge-1.21.11/src/main/java/aurick/opsec/mod/config/LunarVersionSettingsScreen.java
  • neoforge-1.21.11/src/main/java/aurick/opsec/mod/config/OpsecConfig.java
  • neoforge-1.21.11/src/main/java/aurick/opsec/mod/config/OpsecConfigScreen.java
  • neoforge-1.21.11/src/main/java/aurick/opsec/mod/config/OpsecHubScreen.java
  • neoforge-1.21.11/src/main/java/aurick/opsec/mod/config/OpsecScreens.java
  • neoforge-1.21.11/src/main/java/aurick/opsec/mod/config/RuleSettingsScreen.java
  • neoforge-1.21.11/src/main/java/aurick/opsec/mod/config/ScrollableWidgetList.java
  • neoforge-1.21.11/src/main/java/aurick/opsec/mod/config/ServerRule.java
  • neoforge-1.21.11/src/main/java/aurick/opsec/mod/config/SettingsScreen.java
  • neoforge-1.21.11/src/main/java/aurick/opsec/mod/config/SpoofSettings.java
  • neoforge-1.21.11/src/main/java/aurick/opsec/mod/detection/AepProbeDetector.java
  • neoforge-1.21.11/src/main/java/aurick/opsec/mod/lang/OpsecStrings.java
  • neoforge-1.21.11/src/main/java/aurick/opsec/mod/mixin/client/ClientLanguageMixin.java
  • neoforge-1.21.11/src/main/java/aurick/opsec/mod/mixin/client/ClientPacketListenerMixin.java
  • neoforge-1.21.11/src/main/java/aurick/opsec/mod/mixin/client/ConnectionTargetMixin.java
  • neoforge-1.21.11/src/main/java/aurick/opsec/mod/mixin/client/DownloadQueueMixin.java
  • neoforge-1.21.11/src/main/java/aurick/opsec/mod/mixin/client/JoinMultiplayerScreenMixin.java
  • neoforge-1.21.11/src/main/java/aurick/opsec/mod/mixin/client/KeybindContentsMixin.java
  • neoforge-1.21.11/src/main/java/aurick/opsec/mod/mixin/client/ScreenAccessor.java
  • neoforge-1.21.11/src/main/java/aurick/opsec/mod/mixin/client/SeasonalWallpaperMixin.java
  • neoforge-1.21.11/src/main/java/aurick/opsec/mod/mixin/client/ServerNameResolverMixin.java
  • neoforge-1.21.11/src/main/java/aurick/opsec/mod/mixin/client/TabNavigationBarMixin.java
  • neoforge-1.21.11/src/main/java/aurick/opsec/mod/mixin/client/TranslatableContentsMixin.java
  • neoforge-1.21.11/src/main/java/aurick/opsec/mod/net/ServerTargets.java
  • neoforge-1.21.11/src/main/java/aurick/opsec/mod/tracking/ModRegistry.java
  • neoforge-1.21.11/src/main/java/aurick/opsec/mod/util/KeybindDefaults.java
  • neoforge-1.21.11/src/main/resources/META-INF/neoforge.mods.toml
  • neoforge-1.21.11/src/main/resources/assets/opsec/opseclang/de_de.json
  • neoforge-1.21.11/src/main/resources/assets/opsec/opseclang/en_us.json
  • neoforge-1.21.11/src/main/resources/assets/opsec/opseclang/es_es.json
  • neoforge-1.21.11/src/main/resources/assets/opsec/opseclang/fil_ph.json
  • neoforge-1.21.11/src/main/resources/assets/opsec/opseclang/hi_in.json
  • neoforge-1.21.11/src/main/resources/assets/opsec/opseclang/ja_jp.json
  • neoforge-1.21.11/src/main/resources/assets/opsec/opseclang/ko_kr.json
  • neoforge-1.21.11/src/main/resources/assets/opsec/opseclang/ru_ru.json
  • neoforge-1.21.11/src/main/resources/assets/opsec/opseclang/vi_vn.json
  • neoforge-1.21.11/src/main/resources/assets/opsec/opseclang/zh_cn.json
  • neoforge-1.21.11/src/main/resources/assets/opsec/opseclang/zh_tw.json
  • neoforge-1.21.11/src/main/resources/opsec.mixins.json
  • neoforge-26.2/build.gradle
  • neoforge-26.2/gradle.properties
  • neoforge-26.2/src/main/java/aurick/opsec/mod/PrivacyLogger.java
  • neoforge-26.2/src/main/java/aurick/opsec/mod/config/AccountManagerScreen.java
  • neoforge-26.2/src/main/java/aurick/opsec/mod/config/AddAccountScreen.java
  • neoforge-26.2/src/main/java/aurick/opsec/mod/config/AddCrackedAccountScreen.java
  • neoforge-26.2/src/main/java/aurick/opsec/mod/config/CloudflareRelaySettingsScreen.java
  • neoforge-26.2/src/main/java/aurick/opsec/mod/config/GameProxySettingsScreen.java
  • neoforge-26.2/src/main/java/aurick/opsec/mod/config/LunarVersionSettingsScreen.java
  • neoforge-26.2/src/main/java/aurick/opsec/mod/config/OpsecConfig.java
  • neoforge-26.2/src/main/java/aurick/opsec/mod/config/OpsecConfigScreen.java
  • neoforge-26.2/src/main/java/aurick/opsec/mod/config/OpsecHubScreen.java
  • neoforge-26.2/src/main/java/aurick/opsec/mod/config/OpsecScreens.java
  • neoforge-26.2/src/main/java/aurick/opsec/mod/config/RuleSettingsScreen.java
  • neoforge-26.2/src/main/java/aurick/opsec/mod/config/ScrollableWidgetList.java
  • neoforge-26.2/src/main/java/aurick/opsec/mod/config/ServerRule.java
  • neoforge-26.2/src/main/java/aurick/opsec/mod/config/SettingsScreen.java
  • neoforge-26.2/src/main/java/aurick/opsec/mod/config/SpoofSettings.java
  • neoforge-26.2/src/main/java/aurick/opsec/mod/detection/AepProbeDetector.java
  • neoforge-26.2/src/main/java/aurick/opsec/mod/lang/OpsecStrings.java
  • neoforge-26.2/src/main/java/aurick/opsec/mod/mixin/client/ClientLanguageMixin.java
  • neoforge-26.2/src/main/java/aurick/opsec/mod/mixin/client/ClientPacketListenerMixin.java
  • neoforge-26.2/src/main/java/aurick/opsec/mod/mixin/client/ConnectionTargetMixin.java
  • neoforge-26.2/src/main/java/aurick/opsec/mod/mixin/client/DownloadQueueMixin.java
  • neoforge-26.2/src/main/java/aurick/opsec/mod/mixin/client/JoinMultiplayerScreenMixin.java
  • neoforge-26.2/src/main/java/aurick/opsec/mod/mixin/client/KeybindContentsMixin.java
  • neoforge-26.2/src/main/java/aurick/opsec/mod/mixin/client/ScreenAccessor.java
  • neoforge-26.2/src/main/java/aurick/opsec/mod/mixin/client/SeasonalWallpaperMixin.java
  • neoforge-26.2/src/main/java/aurick/opsec/mod/mixin/client/ServerNameResolverMixin.java
  • neoforge-26.2/src/main/java/aurick/opsec/mod/mixin/client/TabNavigationBarMixin.java
  • neoforge-26.2/src/main/java/aurick/opsec/mod/mixin/client/TranslatableContentsMixin.java
  • neoforge-26.2/src/main/java/aurick/opsec/mod/net/ServerTargets.java
  • neoforge-26.2/src/main/java/aurick/opsec/mod/tracking/ModRegistry.java
  • neoforge-26.2/src/main/java/aurick/opsec/mod/util/KeybindDefaults.java
  • neoforge-26.2/src/main/resources/META-INF/neoforge.mods.toml
  • neoforge-26.2/src/main/resources/assets/opsec/opseclang/de_de.json
  • neoforge-26.2/src/main/resources/assets/opsec/opseclang/en_us.json
  • neoforge-26.2/src/main/resources/assets/opsec/opseclang/es_es.json
  • neoforge-26.2/src/main/resources/assets/opsec/opseclang/fil_ph.json
  • neoforge-26.2/src/main/resources/assets/opsec/opseclang/hi_in.json
  • neoforge-26.2/src/main/resources/assets/opsec/opseclang/ja_jp.json
  • neoforge-26.2/src/main/resources/assets/opsec/opseclang/ko_kr.json
  • neoforge-26.2/src/main/resources/assets/opsec/opseclang/ru_ru.json
  • neoforge-26.2/src/main/resources/assets/opsec/opseclang/vi_vn.json
  • neoforge-26.2/src/main/resources/assets/opsec/opseclang/zh_cn.json
  • neoforge-26.2/src/main/resources/assets/opsec/opseclang/zh_tw.json
  • neoforge-26.2/src/main/resources/opsec.mixins.json
  • neoforge/build.gradle
  • neoforge/gradle.properties
  • neoforge/src/main/java/aurick/opsec/mod/PrivacyLogger.java
  • neoforge/src/main/java/aurick/opsec/mod/config/AccountManagerScreen.java
  • neoforge/src/main/java/aurick/opsec/mod/config/AddAccountScreen.java
  • neoforge/src/main/java/aurick/opsec/mod/config/AddCrackedAccountScreen.java
  • neoforge/src/main/java/aurick/opsec/mod/config/CloudflareRelaySettingsScreen.java
  • neoforge/src/main/java/aurick/opsec/mod/config/GameProxySettingsScreen.java
  • neoforge/src/main/java/aurick/opsec/mod/config/LunarVersionSettingsScreen.java
  • neoforge/src/main/java/aurick/opsec/mod/config/OpsecConfig.java
  • neoforge/src/main/java/aurick/opsec/mod/config/OpsecConfigScreen.java
  • neoforge/src/main/java/aurick/opsec/mod/config/OpsecHubScreen.java
  • neoforge/src/main/java/aurick/opsec/mod/config/OpsecScreens.java
  • neoforge/src/main/java/aurick/opsec/mod/config/RuleSettingsScreen.java
  • neoforge/src/main/java/aurick/opsec/mod/config/ScrollableWidgetList.java
  • neoforge/src/main/java/aurick/opsec/mod/config/ServerRule.java
  • neoforge/src/main/java/aurick/opsec/mod/config/SettingsScreen.java
  • neoforge/src/main/java/aurick/opsec/mod/config/SpoofSettings.java
  • neoforge/src/main/java/aurick/opsec/mod/detection/AepProbeDetector.java
  • neoforge/src/main/java/aurick/opsec/mod/lang/OpsecStrings.java
  • neoforge/src/main/java/aurick/opsec/mod/mixin/client/ClientLanguageMixin.java
  • neoforge/src/main/java/aurick/opsec/mod/mixin/client/ClientPacketListenerMixin.java
  • neoforge/src/main/java/aurick/opsec/mod/mixin/client/ConnectionTargetMixin.java
  • neoforge/src/main/java/aurick/opsec/mod/mixin/client/DownloadQueueMixin.java
  • neoforge/src/main/java/aurick/opsec/mod/mixin/client/JoinMultiplayerScreenMixin.java
  • neoforge/src/main/java/aurick/opsec/mod/mixin/client/KeybindContentsMixin.java
  • neoforge/src/main/java/aurick/opsec/mod/mixin/client/ScreenAccessor.java
  • neoforge/src/main/java/aurick/opsec/mod/mixin/client/SeasonalWallpaperMixin.java
  • neoforge/src/main/java/aurick/opsec/mod/mixin/client/ServerNameResolverMixin.java
  • neoforge/src/main/java/aurick/opsec/mod/mixin/client/TabNavigationBarMixin.java
  • neoforge/src/main/java/aurick/opsec/mod/mixin/client/TranslatableContentsMixin.java
  • neoforge/src/main/java/aurick/opsec/mod/net/ServerTargets.java
  • neoforge/src/main/java/aurick/opsec/mod/tracking/ModRegistry.java
  • neoforge/src/main/java/aurick/opsec/mod/util/KeybindDefaults.java
  • neoforge/src/main/resources/META-INF/neoforge.mods.toml
  • neoforge/src/main/resources/assets/opsec/opseclang/de_de.json
  • neoforge/src/main/resources/assets/opsec/opseclang/en_us.json
  • neoforge/src/main/resources/assets/opsec/opseclang/es_es.json
  • neoforge/src/main/resources/assets/opsec/opseclang/fil_ph.json
  • neoforge/src/main/resources/assets/opsec/opseclang/hi_in.json
  • neoforge/src/main/resources/assets/opsec/opseclang/ja_jp.json
  • neoforge/src/main/resources/assets/opsec/opseclang/ko_kr.json
  • neoforge/src/main/resources/assets/opsec/opseclang/ru_ru.json
  • neoforge/src/main/resources/assets/opsec/opseclang/vi_vn.json
  • neoforge/src/main/resources/assets/opsec/opseclang/zh_cn.json
  • neoforge/src/main/resources/assets/opsec/opseclang/zh_tw.json
  • neoforge/src/main/resources/opsec.mixins.json
  • src/client/java/aurick/opsec/mod/PrivacyLogger.java
  • src/client/java/aurick/opsec/mod/config/AccountManagerScreen.java
  • src/client/java/aurick/opsec/mod/config/AddAccountScreen.java
  • src/client/java/aurick/opsec/mod/config/AddCrackedAccountScreen.java
  • src/client/java/aurick/opsec/mod/config/CloudflareRelaySettingsScreen.java
  • src/client/java/aurick/opsec/mod/config/GameProxySettingsScreen.java
  • src/client/java/aurick/opsec/mod/config/LunarVersionSettingsScreen.java
  • src/client/java/aurick/opsec/mod/config/OpsecConfig.java
  • src/client/java/aurick/opsec/mod/config/OpsecConfigScreen.java
  • src/client/java/aurick/opsec/mod/config/OpsecHubScreen.java
  • src/client/java/aurick/opsec/mod/config/OpsecModMenuIntegration.java
  • src/client/java/aurick/opsec/mod/config/OpsecScreens.java
  • src/client/java/aurick/opsec/mod/config/RuleSettingsScreen.java
  • src/client/java/aurick/opsec/mod/config/ScrollableWidgetList.java
  • src/client/java/aurick/opsec/mod/config/ServerRule.java
  • src/client/java/aurick/opsec/mod/config/SettingsScreen.java
  • src/client/java/aurick/opsec/mod/config/SpoofSettings.java
  • src/client/java/aurick/opsec/mod/detection/AepProbeDetector.java
  • src/client/java/aurick/opsec/mod/lang/OpsecStrings.java
  • src/client/java/aurick/opsec/mod/mixin/MeteorMixinCanceller.java
  • src/client/java/aurick/opsec/mod/mixin/client/ClientLanguageMixin.java
  • src/client/java/aurick/opsec/mod/mixin/client/ClientPacketListenerMixin.java
  • src/client/java/aurick/opsec/mod/mixin/client/ConnectionTargetMixin.java
  • src/client/java/aurick/opsec/mod/mixin/client/DownloadQueueMixin.java
  • src/client/java/aurick/opsec/mod/mixin/client/JoinMultiplayerScreenMixin.java
  • src/client/java/aurick/opsec/mod/mixin/client/KeybindContentsMixin.java
  • src/client/java/aurick/opsec/mod/mixin/client/ScreenAccessor.java
  • src/client/java/aurick/opsec/mod/mixin/client/SeasonalWallpaperMixin.java
  • src/client/java/aurick/opsec/mod/mixin/client/ServerNameResolverMixin.java
  • src/client/java/aurick/opsec/mod/mixin/client/TabNavigationBarMixin.java
  • src/client/java/aurick/opsec/mod/mixin/client/TranslatableContentsMixin.java
  • src/client/java/aurick/opsec/mod/net/ServerTargets.java
  • src/client/java/aurick/opsec/mod/tracking/ModRegistry.java
  • src/client/java/aurick/opsec/mod/util/KeybindDefaults.java
  • src/client/resources/opsec.client.mixins.json
  • src/main/resources/assets/opsec/opseclang/de_de.json
  • src/main/resources/assets/opsec/opseclang/en_us.json
  • src/main/resources/assets/opsec/opseclang/es_es.json
  • src/main/resources/assets/opsec/opseclang/fil_ph.json
  • src/main/resources/assets/opsec/opseclang/hi_in.json
  • src/main/resources/assets/opsec/opseclang/ja_jp.json
  • src/main/resources/assets/opsec/opseclang/ko_kr.json
  • src/main/resources/assets/opsec/opseclang/ru_ru.json
  • src/main/resources/assets/opsec/opseclang/vi_vn.json
  • src/main/resources/assets/opsec/opseclang/zh_cn.json
  • src/main/resources/assets/opsec/opseclang/zh_tw.json
  • src/main/resources/fabric.mod.json
  • versions/1.20.1/gradle.properties
  • versions/1.20.2/gradle.properties
  • versions/1.20.4/gradle.properties
  • versions/1.20.6/gradle.properties
  • versions/1.21.1/gradle.properties
  • versions/1.21.11/gradle.properties
  • versions/1.21.4/gradle.properties
  • versions/1.21.6/gradle.properties
  • versions/1.21.9/gradle.properties
  • versions/26.1/gradle.properties
  • versions/26.2/gradle.properties
  • versions/26.3/gradle.properties

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@SU4G3 SU4G3 self-assigned this Nov 20, 2026

@SU4G3 SU4G3 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The per-server rules feature makes sense, but I would hold this PR until the rule is applied before connection setup and the target binding is made reliable.

  1. The active rule is selected at the tail of ClientPacketListener.handleLogin (ClientPacketListenerMixin.java:108-126). GameConnectionProxyMixin reads config.getSettings() while Connection.connect is opening the socket (GameConnectionProxyMixin.java:63-97). A proxy configured only in a server rule therefore cannot route that server's initial connection: the global/ANY setting is used instead, potentially connecting directly. Other settings used during the handshake may also see the wrong rule. Please select the target rule before these consumers run and verify the connection path in a running client.

  2. ServerTargets.claim() falls back to PENDING.peekLast() when the dialed IP does not match (ServerTargets.java:77-96). This queue also receives status-ping resolutions. With concurrent or stale captures, a connection can inherit another server's typed host and use its settings. Please bind the capture to the specific connection without guessing from a shared last-in queue; if the target is unknown, fall back to ANY safely. Test concurrent pings/connections and proxy or redirect cases.

  3. SeasonalWallpaperMixin removed the Season.NONE return. NONE now draws the tree texture on OpSec screens because the icon expression selects TREE for every non-HALLOWEEN value (SeasonalWallpaperMixin.java:70-85). Please restore the guard.

The build results in the PR are useful, but the description says the changed behavior was not exercised in a launched client. Please run the relevant connection and UI scenarios before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants