Skip to content

fix(ci): cargo fmt + allow clippy too_many_arguments on trades routes #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hardyjosh wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ci): cargo fmt + allow clippy too_many_arguments on trades routes #93

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/routes/orders/get_by_owner.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,13 @@ pub(crate) async fn process_get_orders_by_owner(
// Map quote results back to original order positions
let mut io_ratios: Vec<String> = vec!["-".into(); orders.len()];
for (qi, &original_idx) in quotable_indices.iter().enumerate() {
io_ratios[original_idx] = super::quote_result_to_io_ratio(&orders[original_idx], quote_results.get(qi).cloned().unwrap_or_else(|| Err(ApiError::Internal("missing quote".into()))));
io_ratios[original_idx] = super::quote_result_to_io_ratio(
&orders[original_idx],
quote_results
.get(qi)
.cloned()
.unwrap_or_else(|| Err(ApiError::Internal("missing quote".into()))),
);
}

let mut summaries = Vec::with_capacity(orders.len());
Expand Down
8 changes: 7 additions & 1 deletion src/routes/orders/get_by_token.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,13 @@ pub(crate) async fn process_get_orders_by_token(
// Map quote results back to original order positions
let mut io_ratios: Vec<String> = vec!["-".into(); orders.len()];
for (qi, &original_idx) in quotable_indices.iter().enumerate() {
io_ratios[original_idx] = super::quote_result_to_io_ratio(&orders[original_idx], quote_results.get(qi).cloned().unwrap_or_else(|| Err(ApiError::Internal("missing quote".into()))));
io_ratios[original_idx] = super::quote_result_to_io_ratio(
&orders[original_idx],
quote_results
.get(qi)
.cloned()
.unwrap_or_else(|| Err(ApiError::Internal("missing quote".into()))),
);
}

let mut summaries = Vec::with_capacity(orders.len());
Expand Down
2 changes: 2 additions & 0 deletions src/routes/trades.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -873,6 +873,7 @@ pub async fn get_trades_by_tx(
)
)]
#[get("/<address>?<params..>", rank = 2)]
#[allow(clippy::too_many_arguments)] // Rocket route handlers naturally accumulate &State<...> params.
pub async fn get_trades_by_address(
_global: GlobalRateLimit,
_key: AuthenticatedKey,
Expand Down Expand Up @@ -921,6 +922,7 @@ pub async fn get_trades_by_address(
)
)]
#[get("/taker/<address>?<params..>")]
#[allow(clippy::too_many_arguments)] // Rocket route handlers naturally accumulate &State<...> params.
pub async fn get_taker_trades(
_global: GlobalRateLimit,
_key: AuthenticatedKey,
Expand Down
Loading