Skip to content

Taker + batch trade endpoints (depends on D, #50, #51)#90

Draft
alastairong1 wants to merge 1 commit intomainfrom
alastair/taker-batch-trades
Draft

Taker + batch trade endpoints (depends on D, #50, #51)#90
alastairong1 wants to merge 1 commit intomainfrom
alastair/taker-batch-trades

Conversation

@alastairong1
Copy link
Copy Markdown
Contributor

Summary

  • GET /v1/trades/taker/{address} — returns paginated market orders (taker transactions) for a given address, using DirectTradesFetcher for tx hash discovery
  • POST /v1/trades/batch — accepts up to 50 order hashes, returns trades grouped by hash with cache-first lookup and DirectTradesFetcher batch fallback
  • New types: TradesBatchRequest, TradesBatchResponse, TradesBatchEntry, TakerTradesResponse

Dependencies

Test plan

  • Taker trades endpoint returns paginated results for known taker address
  • Batch endpoint returns trades grouped by order hash
  • Batch endpoint rejects >50 hashes with 400
  • Cache prevents repeated SQLite queries for same order hashes

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 20, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 466af9b5-3181-48bb-bd8e-286faea97ef6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch alastair/taker-batch-trades

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant