Repository navigation
fix: polish source and symbol cleanup handling - #14
Conversation
An oversized or malformed archive returned by Business Central fell through normalizeAgentError's known-message patterns to INTERNAL_ERROR, whose recovery step tells the caller to report a bc-dev-mcp issue. Server-returned data is a protocol condition, so wrap both bcdev_profile_finish archive reads the way the package path already does. Covers the newly capped sampling extraction and the instrumentation listEntryNames call, which had the same defect. Also bump the README test badge to 670 to match the suite after this PR's two added tests. Claude-Session: https://claude.ai/code/session_01N5EYBe61Bsb6GrC6REm9je
|
Reviewed, and I pushed one commit directly to this branch ( First, the review itself. Verified on
What I changed in
|
Closes the open on-demand-symbols E2E item, which had SaaS Sandbox evidence only because no on-prem target was reachable when #13/#14 landed. Ran core downloadPackage over the real fetch against a local BC28 container: the Microsoft/Application concept package resolved from a 1.0.0.0 minimum without a supplied app ID, installed under an identity-derived filename, and the repeated call returned unchanged at the same digest. Also records that dev/packages 401s without a tenant query parameter on a single-tenant on-prem server, matching the existing hub negotiate behaviour. Claude-Session: https://claude.ai/code/session_0187Px3Vu7Nk4UgqjwbzDef1
Summary
Follow-up cleanup for #13.
warningin the result.SymbolReference.jsondata at the active runtime’s safe text limit.dev/packagesvalidation as an open evidence item because the local BC28 target was unavailable.Validation
bun test: 670 passed, 0 failedbun run typecheck: passedbun run build: passedgit diff --check: passed