Game start button enabled#47
Merged
Merged
Conversation
…ferred to game screen
- changed color type from String to Color in CardDto - removed current found parameter from game state - current found is now computed in game view model - also removed unused chat messages parameter from game state - now the flow that the game view model emits is really a game state (no longer the game message) - corrected a wrong websocket endpoint - added some mapping functions
|
ad-devel
reviewed
May 18, 2026
Collaborator
ad-devel
left a comment
ad-devel
left a comment
There was a problem hiding this comment.
Start button ist jetzt funktional, passt
ad-devel
approved these changes
May 18, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This pull request enables the function of the game start button. Closes #45
Details
Now, when the game start button is pressed (by the host), the game is started. A message is sent via HTTP with the request for a game start. Then, the server changes the parameter game started to true, and all listening lobby members automatically connect to the lobby's websocket and subscribe to the topic. The host then sends another game-start message after some delay, to make sure all members have already subscribed. The server now broadcasts the first game state object and all members can navigate to their respective game screen.
Changes in the codebase
Additional info
N/A
Changes outside the codebase
N/A