Skip to content

Feature/32 clue system#46

Merged
XtophB merged 38 commits into
developmentfrom
feature/32-clue-system
May 18, 2026
Merged

Feature/32 clue system#46
XtophB merged 38 commits into
developmentfrom
feature/32-clue-system

Conversation

@XtophB
Copy link
Copy Markdown
Collaborator

@XtophB XtophB commented May 17, 2026

Context

This PR contains the implementation of a clue system in the front end.

Description

  1. Backend sends GameState to frontend
  2. Frontend extracts the Clue object
  3. Frontend displays clue word and guess amount
  4. Frontend can also submit clues to backend, mapping has been created to match backend

Changes in the code base

  • Refactor GameMessage to match current backend
    • Various files and tests had to be refactored to take enums instead of strings
  • Extraction and sending of clues

Changes outside the code base

N/A

Additional information

N/A

XtophB added 30 commits May 16, 2026 23:25
* we need to extract the word from the clue dto
* we need to set the team so we can verify clue being sent
since we are now usign game state, and game state only holds Team_Role, the temporary fix is to regex the first part.

This is extremely brittle and prone to errors but has to work for sprint 2
@XtophB XtophB marked this pull request as ready for review May 18, 2026 11:34
Copy link
Copy Markdown
Collaborator

@the-only-queen-anna the-only-queen-anna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aktuell kann ich leider nicht approven, da in kombination mit dem backend beim Empfangen des Clues noch die App auf allen Handys im Game crasht. Problem ist ein Mismatch der gesendeten und der erwarteten Datentypen (Im Frontend wird ein ClueDto erwartet, gesendet wird aktuell noch word und remaining guesses getrennt. Senden klappt aber meines Wissens nach, der Error tritt erst danach auf und die Werte sind korrekt im ankommenden JSON enthalten, nur halt als falscher Datentyp.

@@ -555,23 +560,35 @@ fun HintSection(
actions =
KeyboardActions(
onSend = {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplizierter Code hier und auf Line 584, evtl. in eine Methode extrahieren

@sonarqubecloud
Copy link
Copy Markdown

@XtophB XtophB merged commit 1dc4d1f into development May 18, 2026
2 checks passed
@XtophB XtophB linked an issue May 19, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Übergang für Spymaster-Hinweisabgabe

3 participants