Feature/145 flyway migration#146
Merged
Merged
Conversation
We need to decide as a team if duplicates are allowed or not. For now we leave the constraint as is, can be deleted in t he future
Turns out big variant is not as expensive as expected. As most systems run on 64 bit processors, it might have performance increase. Additionally (source reddit)
(source CrunchyData)
Note: each game will have 25 entries in the card table
Need to discuss with team if we want to store chat in the first place. If yes, we need to consider if we want to store time stamp or not
Since it is a 1:1 relation, the id is unnecessary and lobby_code is sufficient
While the diskspace usage stays the same for all values sub 255, the searching might suffer from using large sizes. Also security concerns/ malicious inputs/ wrong inputs can be minimized by not allowing a standard large varchar size
tasaje1
previously approved these changes
Jun 2, 2026
Collaborator
tasaje1
left a comment
tasaje1
left a comment
There was a problem hiding this comment.
in meeting gezeigt lgtm :))
the-only-queen-anna
previously approved these changes
Jun 2, 2026
Collaborator
the-only-queen-anna
left a comment
the-only-queen-anna
left a comment
There was a problem hiding this comment.
LGTM, gemeinsam im discord reviewed.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This PR contains the addition of a flyway script to create the tables in the DB.
Description
We have 5 tables storing the following:
Changes in the code base
Changes outside the code base
N/A
Additional information
Commands