Refactor/backend cleanup#142
Merged
Merged
Conversation
…ntroller to LobbySocketController
|
XtophB
approved these changes
May 28, 2026
Collaborator
XtophB
left a comment
There was a problem hiding this comment.
LGTM, final warnings are fixed.
We have warnings about local field variables in some tests. Can be fixed in the future, we might need the variables in the future
the-only-queen-anna
approved these changes
May 30, 2026
Collaborator
the-only-queen-anna
left a comment
There was a problem hiding this comment.
Grundsätzlich LGTM; sehr saubere Struktur mMn.
LobbySocketController wird aber soweit ich weiß nie verwendet, eventuell überdenken, ob / wofür wir den noch brauchen (Stichwort reconnect?)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
This PR refactors the backend package layout to a clearer feature-oriented structure with explicit layer boundaries (
api,application,domain,infrastructure/shared).Goal: improve maintainability, reduce package ambiguity, and make ownership/responsibilities easier to understand.
What Was Refactored
lobby.apilobby.applicationlobby.domaingame.apigame.applicationgame.domaingame.mappinggame.api.dtochat.apichat.applicationchat.domainchat.api.dtorecovery.applicationrecovery.domain.snapshotrecovery.infrastructureshared.configshared.websocketKey Class Renames
GameController->LobbySocketControllerCardDataTransferObject->CardDtoGameStateDataTransferObject->GameStateDtoNotes
Package Structure (High-Level)