fix: sidebar hint enfin fonctionnel — injection dans parent.document.head - #32
Merged
Conversation
Both st.html() and st.components.v1.html() use iframes. Timers created inside an iframe are tied to its event loop and stop when the iframe is destroyed by a Streamlit re-render — which is why the hint never appeared. Fix: the iframe script injects a <script> element directly into window.parent.document.head. Inline scripts appended to a document execute immediately and synchronously in that document's window context. Their timers run in the main page event loop and survive re-renders. The iframe script is guarded by window.parent._sbHintInit so it only injects once. The main-page script is guarded by window._sbRunInit. The poll only dismisses after window._sbShowing is true (set by the 20 s timer) to prevent premature sbVisited. https://claude.ai/code/session_01VTBKKYLiAQ6mDPdmVhpRAT
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Diagnostic root cause
st.html()etst.components.v1.html()utilisent tous les deux des iframes. Les timers créés dans un iframe sont liés à son event loop — quand Streamlit re-render la page et recrée l'iframe, les timers s'arrêtent. C'est pourquoi la flèche n'apparaissait jamais : lesetTimeout(20s)mourait avant d'avoir eu le temps de déclencher.Fix
Le script dans l'iframe injecte un élément
<script>directement danswindow.parent.document.head:Les scripts inline ajoutés dynamiquement s'exécutent immédiatement et synchroniquement dans le contexte de la fenêtre principale. Leurs timers tournent dans l'event loop de la page principale et survivent aux re-renders.
Guards
window.parent._sbHintInit: le script iframe ne s'injecte qu'une foiswindow._sbRunInit: le script principal ne tourne qu'une foiswindow._sbShowing: le poll ne peut dismisser qu'après que le timer de 20s a effectivement affiché la flèche (évite lesbVisitedprématuré si la sidebar était déjà ouverte au chargement)Plan de test
https://claude.ai/code/session_01VTBKKYLiAQ6mDPdmVhpRAT
Generated by Claude Code