fix: sidebar hint — st.html() + correction de la logique d'affichage - #31
Merged
Conversation
Two bugs fixed: 1. Deprecation warning: replace st.components.v1.html with st.html() (available since Streamlit 1.36). st.html() renders inline in the main window so scripts execute without an iframe; window.parent and the associated cross-origin complexity are no longer needed. 2. Arrow never appeared: the previous poll called sidebarIsOpen() every 400 ms and immediately set sbVisited='1' when the sidebar was already open on load, preventing the hint from ever showing. Fixed by introducing window._sbShowing: the poll only dismisses after the timer has actually made the hint visible. Also inverted the helper to sidebarIsClosed() (truthy = toggle button exists and is visible) to make the intent unambiguous. https://claude.ai/code/session_01VTBKKYLiAQ6mDPdmVhpRAT
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deux bugs corrigés
1. Avertissement de dépréciation : remplacer
st.components.v1.htmlparst.html()st.html()(disponible depuis Streamlit 1.36) rend le HTML inline dans la fenêtre principale — les scripts s'exécutent directement, sans iframe. Plus besoin dewindow.parent, la complexité cross-origin disparaît.2. La flèche n'apparaissait jamais
Le poll
setIntervalvérifiaitsidebarIsOpen()toutes les 400 ms dès le démarrage. Si la sidebar était déjà ouverte au chargement (ce qui est le cas par défaut), il posait immédiatementsbVisited='1'dans le sessionStorage — empêchant définitivement l'apparition de la flèche.Fix : introduction de
window._sbShowing. Le poll ne dismissit que si la flèche est déjà visible. Le timer de 20s vérifie que la sidebar est fermée avant d'afficher, puis passe_sbShowing = true.Flux corrigé :
_sbShowing = false)_sbShowingest false)_sbShowing = true_sbShowing && !sidebarIsClosed()→ dismiss +sbVisitedPlan de test
https://claude.ai/code/session_01VTBKKYLiAQ6mDPdmVhpRAT
Generated by Claude Code