fix: sidebar hint — texte correct et disparition à l'ouverture - #30
Merged
Conversation
Two bugs fixed:
1. Wrong text ("app.sidebar_hint" key instead of translation):
The innerHTML was built by JS string concatenation which broke when
hint_label was injected. Now the full innerHTML is assembled in
Python (where t() is guaranteed to work) and passed as a single
JSON string: h.innerHTML = <single-json-string>.
2. Arrow not dismissing on sidebar open:
The setTimeout/setInterval were scoped to the iframe which Streamlit
destroys on each re-render, losing the event listeners. Fixed by
storing timers on window.parent (_sbTimer, _sbPoll) so they survive
re-renders. Sidebar state is now detected by polling for the
collapsed-control button disappearing rather than relying on a
click event that could be missed.
https://claude.ai/code/session_01VTBKKYLiAQ6mDPdmVhpRAT
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deux bugs corrigés
1. Texte affiché = clé de traduction ("app.sidebar_hint")
L'ancienne implémentation construisait l'
innerHTMLpar concaténation JS :Fix : l'
innerHTMLcomplet est maintenant assemblé côté Python (oùt()fonctionne garantis), puis passé comme un seul string JSON :2. La flèche ne disparaissait pas à l'ouverture de la sidebar
Les
setTimeout/setIntervalétaient scopés à l'iframe que Streamlit détruit à chaque re-render, perdant ainsi les event listeners.Fix :
window.parent(win._sbTimer,win._sbPoll) → survivent aux re-rendersstSidebarCollapsedControla disparu) plutôt que par un click event qui pouvait être ratéPlan de test
https://claude.ai/code/session_01VTBKKYLiAQ6mDPdmVhpRAT
Generated by Claude Code