fix: sidebar hint arrow now actually executes (st_components.html) - #28
Merged
Conversation
st.markdown strips <script> tags (React sanitises them). Switch to streamlit.components.v1.html() which renders in an iframe where JS runs, then reach the parent page via window.parent.document and window.parent.sessionStorage. https://claude.ai/code/session_01VTBKKYLiAQ6mDPdmVhpRAT
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$(cat <<'EOF'
Problem
The animated ↖ arrow hint was injected via
st.markdown(..., unsafe_allow_html=True)which does not execute<script>tags — React sanitises them viadangerouslySetInnerHTML. The timer never fired, so the hint never appeared.Fix
Switch to
streamlit.components.v1.html(), which renders in a sandboxed iframe where JavaScript does execute. The script then reaches the main Streamlit page via:window.parent.document— to inject the<style>and hint<div>into the real page DOMwindow.parent.sessionStorage— to persist the "already visited" flag across re-renderswindow.parent._sbHintInit— to prevent re-execution on Streamlit re-rendersThe hint logic is otherwise unchanged: appears after 20 s if the sidebar has never been opened, disappears on sidebar click, never shown again once dismissed.
Test plan
https://claude.ai/code/session_01VTBKKYLiAQ6mDPdmVhpRAT
EOF
)
Generated by Claude Code