Conversation
|
Follow-up on the methanol GLOA correctness question: This PR fixes the benchmark summary import path so the installed I tested the focused methanol GLOA path against Pyomo/pyomo#3940, which fixes GLOA convex affine cut generation:
The patched Pyomo result matches the documented methanol best-known objective Implication for this PR: #128 is still useful because it makes the benchmark CLI complete successfully after a methanol GLOA run, but we should not claim the current GDPlib dependency stack fixes GLOA optimality until the Pyomo fix is merged and available in the environment used for verification. |
ef4b00c to
58c0961
Compare
|
Objective-sense note (context: Pyomo/pyomo#3986, merged 2026-08-13, fixed the GDPopt LOA objective-sense bug tracked in #114): No changes needed here — this PR's scope is GLOA benchmark summary generation, and the fix was LOA-only (GLOA passes the objective sense through correctly), so the verification evidence stands. The related follow-up — reverting methanol's |
Summary
gdplib.benchmark_summaryso the installedgdplib-benchmarkentry point can generate summaries without importing a repo-root-only script.generate_benchmark_summary_all.pyas a compatibility wrapper around the packaged implementation.gdpopt.gloaresult JSON to cover summary generation from benchmark result folders.pixi.lock.Tests run
/home/bernalde/.pixi/bin/pixi run pytest tests/test_benchmark.py::test_generate_summary_uses_packaged_summary_module -v --tb=short- passed./home/bernalde/.pixi/bin/pixi run pytest tests/test_methanol.py -v --tb=short- passed, 3 tests./home/bernalde/.pixi/bin/pixi run pytest 'tests/test_module_imports.py::TestModelConstruction::test_model_construction[methanol]' -v --tb=short- passed./home/bernalde/.pixi/bin/pixi run pytest tests/test_benchmark.py -v --tb=short- passed, 18 tests./home/bernalde/.pixi/bin/pixi run test- passed, 282 passed and 1 skipped./home/bernalde/.pixi/bin/pixi run lint- passed. The non-blockingflake8 --exit-zerostep still reports existing repository warnings./home/bernalde/.pixi/bin/pixi run gdplib-benchmark run --instances methanol --strategies gdpopt.gloa --timelimit 60 --solver-profile gams-baron --run-id issue70_methanol_gloa_final_verify- passed with 1 result row, 0 failures, summary generated. Solver result:optimal, objective-1743.4292381783366.Notes about tests not run
methanolto fix benchmark issues #70.Closes #70