Feat/760 UI components for emergency overlays#779
Open
melaniereis wants to merge 13 commits into
Open
Conversation
…ve C++ files (qml shouldn't have this kind of code)
…etter code standards and optimization
…/561-optimize-qt-dashboard
5 tasks
|
✅ STM32 CI: firmware build succeeded
|
🔍 TSF Validation Results
📋 Lint Output📊 Traceability Graph✅ Graph generated successfully Download artifacts to view: TSF Validation Results
🧪 Unit Test ResultsOverall Status: ✅ PASSED
📊 CoverageCoverage report available in artifacts. 🔍 Coverage Change Validation
Full coverage reports available in workflow artifacts 🔒 CodeQL (filtered SARIF summary)
🧪 Unit Test ResultsOverall Status: ✅ PASSED
📊 CoverageCoverage report available in artifacts. 🔍 Coverage Change Validation
Full coverage reports available in workflow artifacts
|
Hugofslopes
requested changes
Jun 17, 2026
Hugofslopes
left a comment
Contributor
There was a problem hiding this comment.
Great job, just got one question regarding some comments
Contributor
There was a problem hiding this comment.
Why all of this lines, after line 125, are commented ? If they will not be used should be deleted no?
Contributor
|
@Hugofslopes ??? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue(s): Closes #760, Closes #561, Closes #562
Type of change
Summary
This PR introduces the V2X Emergency UI, optimizes Qt/Feeder performance, and cleans up the codebase.
How to test / Validation
UI Testing:
ClusterScreen.qml.Performance Testing:
Checklist
Risks and backward compatibility
Related / dependent PRs
Blocks #761
Approval: Requires a minimum of 2 approvals.
Action: The feature branch MUST be deleted upon successful merge.