Skip to content

Feat/760 UI components for emergency overlays#779

Open
melaniereis wants to merge 13 commits into
masterfrom
feat/760-ui-components-for-emergency-overlays
Open

Feat/760 UI components for emergency overlays#779
melaniereis wants to merge 13 commits into
masterfrom
feat/760-ui-components-for-emergency-overlays

Conversation

@melaniereis

@melaniereis melaniereis commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Pull Request

Related issue(s): Closes #760, Closes #561, Closes #562

Type of change

  • feat: A new feature
  • fix: A bug fix
  • docs: Documentation only changes
  • style: Formatting, missing semicolons, etc (no code change)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: A code change that improves performance
  • test: Adding or updating tests
  • ci: CI configuration changes
  • chore: Maintenance tasks
  • spike: Investigation / research

Summary

This PR introduces the V2X Emergency UI, optimizes Qt/Feeder performance, and cleans up the codebase.

How to test / Validation

UI Testing:

  1. Set property bool demoEmergencyAlert: true in ClusterScreen.qml.
  2. Build (cmake -S . -B build && cmake --build build) and run (./build/myqtapp).
  3. Verify the "EMERGENCY VEHICLE" banner drops down every 10 seconds.
  4. Click the bottom bar reset button to verify the odometer resets to 0.
  5. Note: Revert demoEmergencyAlert to false before merging.

Performance Testing:

  1. Run kuksa_feeder with CAN traffic (e.g., cangen).
  2. Monitor htop to confirm reduced CPU usage from the new O(1) table.

Checklist

  • I have run the project tests locally and they pass
  • CI checks are green for this branch (or I will fix any failures)
  • I have added or updated tests where applicable
  • I have updated documentation (if applicable)
  • I have added/updated any migration notes (if database or protocol changes)
  • I have requested appropriate reviewers and added labels if needed
  • This PR contains no secrets or sensitive data

Risks and backward compatibility

  • Feeder Bounds: The O(1) table is sized for 11-bit CAN IDs (2048 slots). Extended 29-bit frames are not supported and may cause a segfault without bounds checking.
  • UI: Emergency alert defaults to safely hidden (isActive: false), preventing false positives.

Related / dependent PRs

Blocks #761


Approval: Requires a minimum of 2 approvals.

Action: The feature branch MUST be deleted upon successful merge.

@melaniereis melaniereis self-assigned this Jun 16, 2026
@melaniereis melaniereis linked an issue Jun 16, 2026 that may be closed by this pull request
5 tasks
@github-actions

Copy link
Copy Markdown

✅ STM32 CI: firmware build succeeded

@github-actions

Copy link
Copy Markdown

🔍 TSF Validation Results

Check Status
trudag lint ✅ PASSED
trudag score ✅ PASSED
trudag publish ✅ PASSED

📋 Lint Output

WARNING: Unreviewed Item: HLTC-INT-PS3_DECODE_VALIDATE
WARNING: Unreviewed Item: LLTC-DC_MOTOR_UNIT
WARNING: Unreviewed Item: LLTC-SERVO_MOTOR_UNIT
WARNING: Unreviewed Item: LLTC-SPEED_SENSOR_UNIT
WARNING: Unreviewed Item: SWD-DC_MOTOR_DRIVER
WARNING: Unreviewed Item: SWD-SERVO_DRIVER
WARNING: Unreviewed Item: SWD-SPEED_CALC
WARNING: Suspect Link: SRD-ACT-MOTOR_DRIVE -> SWD-DC_MOTOR_DRIVER
WARNING: Suspect Link: SRD-ACT-SERVO_STEER -> SWD-SERVO_DRIVER
WARNING: Suspect Link: SRD-SENS-ENCODER_SPD 

📊 Traceability Graph

✅ Graph generated successfully

Download artifacts to view: TSF Validation Results

  • Traceability graph: tsf-validation-artifacts/traceability_graph.svg
  • Full TSF reports in artifact archive

🧪 Unit Test Results

Overall Status: ✅ PASSED

  • DC Motor Tests: PASSED (11/11)
  • Servo Motor Tests: PASSED (5/5)
  • Speed Sensor Tests: PASSED (16/16)
  • Total: 32 tests

📊 Coverage

Coverage report available in artifacts.

🔍 Coverage Change Validation

  • dc-motor: score=1.00 issues=[]
  • servo-motor: score=1.00 issues=[]
  • speed-sensor: score=1.00 issues=[]

Full coverage reports available in workflow artifacts


🔒 CodeQL (filtered SARIF summary)

Severity Count
High/Critical (error) 0
Warnings 0
Notes 0

🧪 Unit Test Results

Overall Status: ✅ PASSED

  • DC Motor Tests: PASSED (11/11)
  • Servo Motor Tests: PASSED (5/5)
  • Speed Sensor Tests: PASSED (16/16)
  • Total: 32 tests

📊 Coverage

Coverage report available in artifacts.

🔍 Coverage Change Validation

  • dc-motor: score=1.00 issues=[]
  • servo-motor: score=1.00 issues=[]
  • speed-sensor: score=1.00 issues=[]

Full coverage reports available in workflow artifacts

Run: https://github.com/SEAME-pt/Team04_DrivaPi/actions/runs/27623710313

@Hugofslopes Hugofslopes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, just got one question regarding some comments

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why all of this lines, after line 125, are commented ? If they will not be used should be deleted no?

@Hugofslopes

Hugofslopes commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

@Hugofslopes ???

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants