Skip to content

OUP: update ROR extraction to return full URL #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PascalEgn merged 1 commit into from
Apr 29, 2026
Merged

OUP: update ROR extraction to return full URL #302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dags/oup/parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ def _extract_ror_from_text(self, text):
match = re.search(ROR_PATTERN, text, re.IGNORECASE)

if match:
return match.group(1)
return match.group(0)
return None

def _clean_affiliation_text(self, text):
Expand Down
20 changes: 10 additions & 10 deletions tests/units/oup/test_oup_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -751,7 +751,7 @@ def test_author_parsing_with_ror(shared_datadir, parser):
"value": "Department of Physics, Faculty of Science, Kyoto University, Kyoto 606-8502, Japan",
"organization": "Kyoto University",
"country": "Japan",
"ror": "02kpeqv85",
"ror": "https://ror.org/02kpeqv85",
}
],
},
Expand All @@ -764,7 +764,7 @@ def test_author_parsing_with_ror(shared_datadir, parser):
"value": "Department of Physics, Faculty of Science, Kyoto University, Kyoto 606-8502, Japan",
"organization": "Kyoto University",
"country": "Japan",
"ror": "02kpeqv85",
"ror": "https://ror.org/02kpeqv85",
}
],
},
Expand All @@ -777,13 +777,13 @@ def test_author_parsing_with_ror(shared_datadir, parser):
"value": "Department of Physics, Faculty of Science, Kyoto University, Kyoto 606-8502, Japan",
"organization": "Kyoto University",
"country": "Japan",
"ror": "02kpeqv85",
"ror": "https://ror.org/02kpeqv85",
},
{
"value": "Hakubi Center for Advanced Research, Kyoto University, Kyoto 606-8501, Japan",
"organization": "Kyoto University",
"country": "Japan",
"ror": "02kpeqv85",
"ror": "https://ror.org/02kpeqv85",
},
],
},
Expand All @@ -796,7 +796,7 @@ def test_author_parsing_with_ror(shared_datadir, parser):
"value": "Department of Physics, Faculty of Science, Kyoto University, Kyoto 606-8502, Japan",
"organization": "Kyoto University",
"country": "Japan",
"ror": "02kpeqv85",
"ror": "https://ror.org/02kpeqv85",
}
],
},
Expand All @@ -821,7 +821,7 @@ def test_author_parsing_with_ror_new(shared_datadir, parser):
"value": "Department of Physics, Faculty of Science, Hokkaido University, Sapporo 060-0810, Japan",
"organization": "Hokkaido University",
"country": "Japan",
"ror": "02e16g702",
"ror": "https://ror.org/02e16g702",
}
],
},
Expand All @@ -834,7 +834,7 @@ def test_author_parsing_with_ror_new(shared_datadir, parser):
"value": "Department of Physics, Faculty of Science, Kyoto University, Kyoto 606-8502, Japan",
"organization": "Kyoto University",
"country": "Japan",
"ror": "02kpeqv85",
"ror": "https://ror.org/02kpeqv85",
}
],
},
Expand All @@ -847,13 +847,13 @@ def test_author_parsing_with_ror_new(shared_datadir, parser):
"value": "Department of Physics, Faculty of Science, Kyoto University, Kyoto 606-8502, Japan",
"organization": "Kyoto University",
"country": "Japan",
"ror": "02kpeqv85",
"ror": "https://ror.org/02kpeqv85",
},
{
"value": "Hakubi Center for Advanced Research, Kyoto University, Kyoto 606-8501, Japan",
"organization": "Kyoto University",
"country": "Japan",
"ror": "02kpeqv85",
"ror": "https://ror.org/02kpeqv85",
},
],
},
Expand All @@ -866,7 +866,7 @@ def test_author_parsing_with_ror_new(shared_datadir, parser):
"value": "Department of Physics, Faculty of Science, Kyoto University, Kyoto 606-8502, Japan",
"organization": "Kyoto University",
"country": "Japan",
"ror": "02kpeqv85",
"ror": "https://ror.org/02kpeqv85",
}
],
},
Expand Down
Loading