feat(common): Refactor country processing#270
Open
Lorenzovagliano wants to merge 1 commit into
Open
Conversation
Lorenzovagliano
force-pushed
the
countries_parsing_fix
branch
3 times, most recently
from
84ae365 to
2da4cae
Compare
drjova
requested changes
Jul 18, 2025
Contributor
drjova
left a comment
drjova
left a comment
There was a problem hiding this comment.
I like the approach, few comments :)
Lorenzovagliano
force-pushed
the
countries_parsing_fix
branch
3 times, most recently
from
417f626 to
3d51213
Compare
drjova
requested changes
Jul 22, 2025
Signed-off-by: vaglianolorenzo@gmail.com
Lorenzovagliano
force-pushed
the
countries_parsing_fix
branch
from
3d51213 to
9f6b477
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: cern-sis/issues-scoap3#464